Make the explosions throw the container/item they originated from #32428
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra fun if it's something that can trigger multiple times
2 tasks
VasilisThePikachu
added
the
Undergoing Maintainer Discussion
| @@ -488,9 +488,12 @@ private void ProcessEntity( | |||
| && physics.BodyType == BodyType.Dynamic) | |||
| { | |||
| var pos = _transformSystem.GetWorldPosition(xform); | |||
| var dir = pos - epicenter.Position; | |||
| if (dir.IsLengthZero()) | |||
| dir = _robustRandom.NextVector2().Normalized(); | |||
There was a problem hiding this comment.
Suggested change
| dir = _robustRandom.NextVector2().Normalized(); | |
| dir = _robustRandom.NextVector2(); |
NextVector2 already returns a normalized vector if you don't pass a magnitude.
There was a problem hiding this comment.
NextVector2 actually will generate a vector with magnitude between 0 and 1 (excluding), according to comment and code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Makes the containers containing an explosive (and maybe the explosive itself if it's multitrigger? didn't test) fly away from the epicenter in a random direction.
Why / Balance
Container bombs leave a weirdly still container at the exact spot things detonated. Also if something manages to explode second time, it will happen in an entirely different spot than the first explosion.
Technical details
In explosion throw direction processing code, adds a check for null vector. Generates a random one of normalized magnitude if it is null.
Media
Tested with another edit that makes minibomb not go off right away:
Peek.2024-09-24.12-47.mp4
Requirements
Changelog
🆑