Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the explosions throw the container/item they originated from #32428

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

Make the explosions throw the container/item they originated from #32428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Content.Server/Explosion/EntitySystems/ExplosionSystem.Processing.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,9 +488,12 @@ private void ProcessEntity(
&& physics.BodyType == BodyType.Dynamic)
{
var pos = _transformSystem.GetWorldPosition(xform);
var dir = pos - epicenter.Position;
if (dir.IsLengthZero())
dir = _robustRandom.NextVector2().Normalized();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dir = _robustRandom.NextVector2().Normalized();
dir = _robustRandom.NextVector2();

NextVector2 already returns a normalized vector if you don't pass a magnitude.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NextVector2 actually will generate a vector with magnitude between 0 and 1 (excluding), according to comment and code.

_throwingSystem.TryThrow(
uid,
pos - epicenter.Position,
dir,
physics,
xform,
_projectileQuery,
Expand Down
Loading