-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: proof_of_sql_parser::intermediate_ast::UnaryOp
with sqlparser::ast::UnaryOp
in the proof-of-sql crate
#363
Conversation
3a5c58f
to
1cd95f2
Compare
@varshith257 Let's get #344 merged first so that your PR can be simpler. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor issues. In general this is excellent! Please complete the PR description and fix these issues.
e5664f3
to
2cf0724
Compare
proof_of_sql_parser::intermediate_ast::UnaryOp
with sqlparser::ast::UnaryOp
in the proof-of-sql crate
92192fc
to
8075a5c
Compare
8075a5c
to
7b3c87f
Compare
7b3c87f
to
b9abb8f
Compare
🎉 This PR is included in version 0.43.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!
is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh
.Rationale for this change
This PR addresses the need to replace the
proof_of_sql_parser::intermediate_ast::UnaryOp
with thesqlparser::ast::UnaryOp
in theproof-of-sql
crate as part of a larger transition toward integrating thesqlparser
.This change is a subtask of issue #235, with the main goal of streamlining the repository by switching to the
sqlparser
crate and gradually replacing intermediary constructs likeproof_of_sql_parser::intermediate_ast
withsqlparser::ast
.What changes are included in this PR?
proof_of_sql_parser::intermediate_ast::UnaryOp
have been replaced withsqlparser::ast::UnaryOp
UnaryOp
has been updated to maintain the original functionality, ensuring no changes to the logic or behavior.UnaryOp
variants fromsqlparser
have been appropriately handled using existing error handling mechanisms (i.e., theUnsupported
variant inExpressionEvaluationError
).Are these changes tested?
Yes
Part of #235