Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Verify that previous ATX points to correct ATX when handling incoming ATXs #5927

Closed
wants to merge 35 commits into from

Merge remote-tracking branch 'origin/develop' into cve-fix-integration

ff55625
Select commit
Loading
Failed to load commit list.
Closed

[Merged by Bors] - Verify that previous ATX points to correct ATX when handling incoming ATXs #5927

Merge remote-tracking branch 'origin/develop' into cve-fix-integration
ff55625
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 21, 2024 in 0s

80.8% (-0.1%) compared to 3ed6d3d

View this Pull Request on Codecov

80.8% (-0.1%) compared to 3ed6d3d

Details

Codecov Report

Attention: Patch coverage is 69.28571% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 80.8%. Comparing base (3ed6d3d) to head (ff55625).

Files Patch % Lines
activation/handler_v1.go 76.1% 18 Missing and 12 partials ⚠️
activation/verify_state.go 54.1% 15 Missing and 7 partials ⚠️
malfeasance/wire/malfeasance.go 20.0% 19 Missing and 1 partial ⚠️
node/node.go 0.0% 5 Missing and 1 partial ⚠️
sql/atxs/atxs.go 85.3% 3 Missing and 3 partials ⚠️
events/events.go 0.0% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           develop   #5927     +/-   ##
=========================================
- Coverage     80.8%   80.8%   -0.1%     
=========================================
  Files          286     287      +1     
  Lines        29714   29905    +191     
=========================================
+ Hits         24035   24182    +147     
- Misses        4117    4139     +22     
- Partials      1562    1584     +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov