Verify key.bin against NodeID in metadata #205
Conversation
cmd/postcli/main.go
Outdated
| if cmdVerifyPos(opts, fraction, logger) != nil { | ||
| os.Exit(1) | ||
| } | ||
| os.Exit(0) | ||
| cmdVerifyPos(opts, fraction, logger) |
There was a problem hiding this comment.
Previously it was clear that the program terminates after calling cmdVerifyPos(). Now it's hidden and less obvious. How about returning an error and adding a log.Fatal() here?
There was a problem hiding this comment.
I don't see the benefit? Errors are not logging messages. I changed the code so it is clear it exits after cmdVerifyPos is called.
There was a problem hiding this comment.
Errors are not logging messages.
? The point of CLI is to communicate to the user the outcome. What's wrong with communicating by showing them a nice readable error message?
I don't see the benefit?
The benefit is that the next person reading this code immediately understands that the program terminates here.
There was a problem hiding this comment.
What's wrong with communicating by showing them a nice readable error message?
I did this by updating the errors with your suggestions and printing them directly? Why first wrap them in an error to return them just to print them?
The benefit is that the next person reading this code immediately understands that the program terminates here.
That's why I added the os.Exit(0) as you suggested?
|
|
Closes #198.
Simple verification of the private key in
key.binagainst the NodeID inpostdata_metadata.json. Will be done when-verifyis set.