Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect seed length during verify #207

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix incorrect seed length during verify #207

merged 1 commit into from
Jul 31, 2023

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Jul 31, 2023

In #205 the whole private key is passed to ed25519.NewKeyFromSeed while it should only be the first 32 bytes (the seed - the rest is the public key).

This PR fixes this oversight.

@fasmat fasmat requested a review from poszu July 31, 2023 13:41
@fasmat fasmat self-assigned this Jul 31, 2023
@fasmat fasmat mentioned this pull request Jul 31, 2023
Merged
poszu
poszu approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@poszu poszu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Perhaps postcli deserves some unit tests.

@fasmat
Copy link
Member Author

fasmat commented Jul 31, 2023

👍 Perhaps postcli deserves some unit tests.

Will come with #199

@fasmat fasmat merged commit 3bd3ed4 into develop Jul 31, 2023
@fasmat fasmat deleted the fix-incorrect-seed-length branch July 31, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poszu poszu poszu approved these changes

Assignees

@fasmat fasmat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fasmat @poszu