Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-1412: Get regression tests to pass with python 3.13 #1936

Conversation

s-goldman
Copy link
Collaborator

@s-goldman s-goldman commented Jan 21, 2025

Resolves HLA-1412

Closes #1930

This PR allows drizzlepac to begin testing (and passing) with python 3.13. It adds new python 3.13 devdep tests for both mac and linux for the CI workflow. Once there is a regular 3.13 (non devdep) test available on pytest-xdist, that will also be added.

This does not change the cron job, just the CI workflow (for PRs).

It also removes two warnings that regularly show up in the drizzlepac code, and removes the python<3.13 pin in the pyproject.toml.

A new wheel for stregion was needed to accomodate python 3.13.

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant label(s)

@s-goldman s-goldman added in progress testing Do Not Merge PR which should not be merged labels Jan 21, 2025
@s-goldman s-goldman requested review from mdlpstsci and a team as code owners January 21, 2025 20:46
@s-goldman s-goldman changed the title HLA-1412: Get regression tests to pass with python 3.13 [WIP] HLA-1412: Get regression tests to pass with python 3.13 Jan 21, 2025
@s-goldman s-goldman changed the title [WIP] HLA-1412: Get regression tests to pass with python 3.13 HLA-1412: Get regression tests to pass with python 3.13 Feb 18, 2025
@s-goldman s-goldman added ready-for-final-review and removed in progress Do Not Merge PR which should not be merged labels Feb 18, 2025
@s-goldman
Copy link
Collaborator Author

Tested using spacetelescope/RegressionTests suite and passes.

@s-goldman
Copy link
Collaborator Author

Some of this work was duplicated in #1955 and so this PR is mostly about removing the warnings.

@s-goldman s-goldman merged commit 17a20bb into spacetelescope:main Feb 25, 2025
16 of 17 checks passed
@s-goldman s-goldman deleted the hla-1412_fixing_drizzlepac_for_python_3.13_01_21_25 branch February 25, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drizzlepac/HAP: Begin testing with python 3.13
1 participant