-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLA-1412: Get regression tests to pass with python 3.13 #1936
Merged
s-goldman
merged 16 commits into
spacetelescope:main
from
s-goldman:hla-1412_fixing_drizzlepac_for_python_3.13_01_21_25
Feb 25, 2025
Merged
HLA-1412: Get regression tests to pass with python 3.13 #1936
s-goldman
merged 16 commits into
spacetelescope:main
from
s-goldman:hla-1412_fixing_drizzlepac_for_python_3.13_01_21_25
Feb 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested using spacetelescope/RegressionTests suite and passes. |
Some of this work was duplicated in #1955 and so this PR is mostly about removing the warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves HLA-1412
Closes #1930
This PR allows drizzlepac to begin testing (and passing) with python 3.13. It adds new python 3.13 devdep tests for both mac and linux for the CI workflow. Once there is a regular 3.13 (non devdep) test available on pytest-xdist, that will also be added.
This does not change the cron job, just the CI workflow (for PRs).
It also removes two warnings that regularly show up in the drizzlepac code, and removes the python<3.13 pin in the pyproject.toml.
A new wheel for stregion was needed to accomodate python 3.13.
Checklist for maintainers
CHANGELOG.rst
within the relevant release section