RCAL-853: Give VA scale factor a reasonable default #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stscieisenhamer
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 97.56% 97.01% -0.55%
==========================================
Files 30 37 +7
Lines 2788 3316 +528
==========================================
+ Hits 2720 3217 +497
- Misses 68 99 +31 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
schlafly
reviewed
Oct 10, 2024
stscieisenhamer
force-pushed
the
rcal-853-velocity
branch
2 times, most recently
from
4f0c32a to
4f5d090
Compare
|
The doc issue must be something upstream. I can investigate or leave to others. |
braingram
reviewed
Nov 15, 2024
for more information, see https://pre-commit.ci
This reverts commit 4f5d090.
This reverts commit a98be0f.
Turns out this doesn't need a changelog. This reverts commit 1dde8e7.
stscieisenhamer
force-pushed
the
rcal-853-velocity
branch
from
825201c to
7926b1d
Compare
schlafly
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP RCAL-853
Main PR: PR#1354
This PR gives the
velocity_aberration.scale_factermeta a default working value of 1.0Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)romancalregression test with this branch installed ("git+https://github.com/<fork>/roman_datamodels@<branch>")news fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change