Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-853: Give VA scale factor a reasonable default #396

Merged
merged 9 commits into from
Nov 25, 2024
Merged

RCAL-853: Give VA scale factor a reasonable default #396

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eac1c43
Give VA scale factor a reasonable default
stscieisenhamer Oct 1, 2024
3c46030
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 15, 2024
c75030e
add towncrier update
stscieisenhamer Nov 15, 2024
b36f358
Revert "add towncrier update"
stscieisenhamer Nov 15, 2024
b5adbae
update changelog
stscieisenhamer Nov 15, 2024
efe6d54
Revert "update changelog"
stscieisenhamer Nov 15, 2024
4fbb23a
Try another type of towncrier entry
stscieisenhamer Nov 15, 2024
7926b1d
Revert "Try another type of towncrier entry"
stscieisenhamer Nov 15, 2024
65c7273
Merge branch 'main' into rcal-853-velocity
stscieisenhamer Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/roman_datamodels/maker_utils/_common_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def mk_velocity_aberration(**kwargs):
vab = stnode.VelocityAberration()
vab["ra_reference"] = kwargs.get("ra_reference", NONUM)
vab["dec_reference"] = kwargs.get("dec_reference", NONUM)
vab["scale_factor"] = kwargs.get("scale_factor", NONUM)
vab["scale_factor"] = kwargs.get("scale_factor", 1)
braingram marked this conversation as resolved.
Show resolved Hide resolved

return vab

Expand Down
Loading