RCAL-911 & 932: remove units from MOS and ELP pipelines. #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… ELP (spacetelescope#1373) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zach Burnett <[email protected]> Co-authored-by: Brett <[email protected]>
for more information, see https://pre-commit.ci
schlafly
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Thanks Mairan. This looks great. I left one minor comment about deleting some presently commented-out code. Please spot check one of the L2 and L3 pipeline outputs for unexpected differences but this looks good to me.
FYI, @ddavis-stsci , this contains two sets of changes that touch all of the regtest files:
- changing the regtest filenames to remove the ggsaa component
- removing all of the units.
mairanteodoro
changed the title
mairanteodoro
changed the title
10 tasks
github-actions
bot
added
the
documentation
PaulHuwe
reviewed
Oct 17, 2024
PaulHuwe
reviewed
Oct 17, 2024
schlafly
approved these changes
Oct 17, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-911
Resolves RCAL-932
This PR modifies several files so that units are not used anymore. Additionally, the filename used in the regression tests was changed to remove the
ggsaacomponent.The information about units is still retained in the RAD schema.
Tasks
24Q4_B15(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pageokify_regteststo update the truth filesnews fragment change types...
changes/1445.general.rst: Remove units from romancal.