Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with [email protected] #825

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

staszek998
Copy link

The 4.0.0 release of the marked package contains a breaking change that - guess what - breaks the SimpleMDE's script. The main change is that the marked package does NOT provide a default export anymore.

For more information please see the release notes for [email protected].

The 4.0.0 release of the `marked` package contains a breaking change
that - guess what - breaks the SimpleMDE's script. The main change
is that the `marked` package does NOT provide a default export anymore.

For more information please see [the release notes for
`[email protected]`](https://github.com/markedjs/marked/releases/tag/v4.0.0).
F-loat pushed a commit to F-loat/vue-simplemde that referenced this pull request Dec 15, 2021
The 4.0.0 release of the `marked` package contains a breaking change
that - guess what - breaks the <VueSimpleMDE> component. The main change
is that the `marked` package does NOT provide a default export anymore.

For more information please see the [release notes for
`[email protected]`](https://github.com/markedjs/marked/releases/tag/v4.0.0).
Also, you might be interested in a [related pull request inside the
SimpleMDE repo](sparksuite/simplemde-markdown-editor#825).

Co-authored-by: Stanisław Gregor <[email protected]>
@staszek998
Copy link
Author

@WesCossick, @sparksuite-bot, it would be great if you could look into this 🙂

@marui325
Copy link

marui325 commented Jan 27, 2022

'simplemde.js?ebfb:1417 Uncaught TypeError: marked is not a function'
I have the same problem and I solve it by overwriting the installation(npm install [email protected]), but I still hope to fix it by merging the branch or modifying the import mode in code.

@aptkingston
Copy link

I can't believe all the dependencies in package.json are specified as complete wildcards *. That's absolutely shocking. It means issues like this will continue to happen because any major, breaking changes in any dependencies will be happily pulled in when installing this package.

The project looks dead anyway since it's been 6 years since any updates. Such a shame, it looks like a wonderful editor.

@staszek998
Copy link
Author

Indeed @aptkingston, the project is dead, not updated for a pretty long time... It's somehow comforting, that fixing the marked dependency on the ^3.0.8 version solves the problem efficiently.

BTW: You could be interested in the resolutions field in the Yarn's configuration.

@aptkingston
Copy link

Yea that definitely solves the problem in this case. I actually found https://github.com/Ionaru/easy-markdown-editor which is a fork of this project which is maintained and actually works! So I'm using that now and it's great.

@staszek998
Copy link
Author

Thank's for the griff, @aptkingston! I didn't ever see this package before, don't know how! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants