Fix attempt for Google and "All day". #192
Conversation
| @@ -35,4 +35,12 @@ public function it_correctly_generates_all_day_events_by_dates(): void | |||
| $this->generator()->generate($this->createEventMultipleDaysViaStartEndWithTimezoneLink()) | |||
| ); | |||
| } | |||
|
|
|||
| /** @test */ | |||
| public function it_correctly_generates_all_day_events_by_dates_diff_tz(): void | |||
There was a problem hiding this comment.
I think having this test is beneficial for all generators. How about moving it to the GeneratorTestContract?
There was a problem hiding this comment.
Agreed!
Maybe also moving the ones I added as well?
| } | ||
|
|
||
| $from = (clone $fromDate)->modify('midnight'); | ||
| $from = (clone $fromDate); |
There was a problem hiding this comment.
With my old code, we're removing the hours/days portion. I guess this probably wasn't required and it only was done for non UTC dates.
|
Failing test looks fine as well, just needs a snapshot update |
|
Thanks for the feedback. |
|
Yea, it's a shame we can't test them again the provider itself. |
|
Thanks @vever001 and @atymic |
|
Hi guys, I'm looking forward for the merge :) |
|
Hey @vever001! Is it ready to be reviewed? |
|
Hi @alies-dev, sure please do :) -- |
Context and Purposes
Follow up of #184 and comment #184 (comment)