-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos method and parameter #8
Conversation
Note: as the enum and the method are public, this change will break any code that use any of them Signed-off-by: Arthit Suriyawongkul <[email protected]>
If this change is accepted, further updates of names are needed in https://github.com/spdx/Spdx-Java-Library |
I'm concerned about the breaking changes to the public methods - so I'll label this for the next major release. |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@goneall I have removed the enum renaming and add the default method to the interface (per discussion here: spdx/Spdx-Java-Library#266 (comment) ) - will this address the backward compatibility concern? Also deferring the enum renaming. |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
…-core into fix-enum-spelling
Signed-off-by: Arthit Suriyawongkul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this should work - I'll go ahead and approve / merge in. If it turns out to break something downstream, we can fix it before the next release.
enum:Unkown
->Unknown
getCaseSensisitiveId
->getCaseSensitiveId
caseInsensisitiveId
->caseInsensitiveId
getCaseSensisitiveId
with the same parameter spellingcaseInsensisitiveId
for backward compatibilityNote: as the enum and the method are public, this change will break any code that use any of themMethod
getCaseSensisitiveId
is still available and can be called the same way.Defer the renaming of enum for now, just add a comment to the code.