Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use method colour key in the Builder API graph #12998

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Use method colour key in the Builder API graph #12998

merged 7 commits into from
Oct 11, 2024
+39 −6

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Oct 10, 2024 •
edited
Loading

To show which methods are final/overridable/abstract: https://sphinx--12998.org.readthedocs.build/en/12998/extdev/builderapi.html

@chrisjsewell chrisjsewell mentioned this pull request Oct 10, 2024
Draft
@AA-Turner AA-Turner changed the title [docs] Color Build API UML Use colours in the Builder API UML diagram Oct 10, 2024
timhoffm
timhoffm reviewed Oct 11, 2024
View reviewed changes
doc/extdev/builderapi.rst Outdated Show resolved Hide resolved
timhoffm
timhoffm reviewed Oct 11, 2024
View reviewed changes
doc/extdev/builderapi.rst Outdated Show resolved Hide resolved
@chrisjsewell chrisjsewell changed the title Use colours in the Builder API UML diagram Use colours in the Builder API graph Oct 11, 2024
@chrisjsewell chrisjsewell changed the title Use colours in the Builder API graph Use method colour key in the Builder API graph Oct 11, 2024
timhoffm
timhoffm approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But the colors are not yet changed. Did you forget to push that?

picnixz
picnixz approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A last question, otherwise LGTM.

doc/_static/diagrams/sphinx_build_flow.dot Show resolved Hide resolved
@AA-Turner AA-Turner merged commit c23697a into sphinx-doc:master Oct 11, 2024
8 checks passed
@AA-Turner AA-Turner added this to the 8.1.x milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@timhoffm timhoffm timhoffm approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees
No one assigned
Labels
type:docs
Projects
None yet
Milestone
8.1.x
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisjsewell @timhoffm @picnixz @AA-Turner