refactor(igor): use SpinnakerRetrofitErrorHandler with IgorService #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranav-b-7
force-pushed
the
remove-retrofitError-igorService
branch
from
2ce0b9a
to
1b15fcf
Compare
orca-keel/src/main/kotlin/com/netflix/spinnaker/orca/keel/task/ImportDeliveryConfigTask.kt
Show resolved
Hide resolved
Pranav-b-7
force-pushed
the
remove-retrofitError-igorService
branch
from
1b15fcf
to
50715dc
Compare
This PR lays the foundational work for upgrading the retrofit version to 2.x, specifically focusing on refactoring the exception handling for IgorService. There are no behaviour changes detected with these code changes and hence no additional tests added to demonstrate the functionalities. Few existing tests are modified to align it with the new changes.
Pranav-b-7
force-pushed
the
remove-retrofitError-igorService
branch
2 times, most recently
from
e1e618e
to
30a788b
Compare
There are 2 APIs invoked inside the try block: 1. Keel Service API - keelService.publishDeliveryConfig() : With the addition of the commit - c417922, the keelService uses SpinnakerRetrofitErrorHandler. 2. Igor Service API - scmService.getDeliveryConfigManifest() : With the addition of the commit - d430b75, the igor service uses SpinnakerRetrofitErrorHandler. and hence with the above mentioned commits the catch block with RetrofitError and the handler logics associated with it becomes irrelevant.
Pranav-b-7
force-pushed
the
remove-retrofitError-igorService
branch
from
30a788b
to
32e6571
Compare
dbyron-sf
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays the foundational work for upgrading the retrofit version to 2.x, specifically focusing on refactoring the exception handling for IgorService.
There are no behaviour changes detected with these code changes and hence no additional tests added to demonstrate the functionalities. Few existing tests are modified to align it with the new changes.