Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(igor): use SpinnakerRetrofitErrorHandler with IgorService #4666

Merged
merged 2 commits into from
Mar 7, 2024
Merged

refactor(igor): use SpinnakerRetrofitErrorHandler with IgorService #4666

merged 2 commits into from
Mar 7, 2024

Commits on Mar 7, 2024

  1. refactor(igor): use SpinnakerRetrofitErrorHandler with IgorService 

    This PR lays the foundational work for upgrading the retrofit version to 2.x, specifically focusing on refactoring the exception handling for IgorService.

There are no behaviour changes detected with these code changes and hence no additional tests added to demonstrate the functionalities. Few existing tests are modified to align it with the new changes.
    @Pranav-b-7
    Pranav-b-7 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d430b75 View commit details
    Browse the repository at this point in the history

  2. refactor(keel): Cleanup RetrofitError in ImportDeliveryConfigTask 

    There are 2 APIs invoked inside the try block:
1. Keel Service API - keelService.publishDeliveryConfig() : With the addition of the commit - c417922, the keelService uses SpinnakerRetrofitErrorHandler.
2. Igor Service API - scmService.getDeliveryConfigManifest() : With the addition of the commit - d430b75, the igor service uses SpinnakerRetrofitErrorHandler.

and hence with the above mentioned commits the catch block with RetrofitError and the handler logics associated with it becomes irrelevant.
    @Pranav-b-7
    Pranav-b-7 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    32e6571 View commit details
    Browse the repository at this point in the history