Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependency): add explicit assertj-core dependency while spockframework upgrade to 2.2-groovy-3.0 #4770

Merged
merged 1 commit into from
Aug 2, 2024

Commits on Aug 2, 2024

  1. chore(dependency): add explicit assertj-core dependency while spockfr…

    …amework upgrade to 2.2-groovy-3.0
    
    While upgrading spockframework from 2.0-groovy-3.0 to 2.2-groovy-3.0, encountered below errors during test execution of orca-mine module:
    ```
    /orca/orca-mine/src/test/java/com/netflix/spinnaker/orca/mine/tasks/RegisterCanaryTaskTest.java:22: error: package org.assertj.core.api does not exist
    import static org.assertj.core.api.Assertions.assertThatThrownBy;
                                      ^
    
    /orca/orca-mine/src/test/java/com/netflix/spinnaker/orca/mine/tasks/RegisterCanaryTaskTest.java:150: error: cannot find symbol
        assertThatThrownBy(() -> registerCanaryTask.execute(deployCanaryStage))
        ^
      symbol:   method assertThatThrownBy(()->regist[...]tage))
      location: class RegisterCanaryTaskTest
    ```
    To fix this issue added assertj-core dependency explicitly.
    j-sandy committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    1ac29b6 View commit details
    Browse the repository at this point in the history