Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependency): add explicit assertj-core dependency while spockframework upgrade to 2.2-groovy-3.0 #4770

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

j-sandy
Copy link
Contributor

@j-sandy j-sandy commented Aug 2, 2024

While upgrading spockframework from 2.0-groovy-3.0 to 2.2-groovy-3.0, encountered below errors during test execution of orca-mine module:

/orca/orca-mine/src/test/java/com/netflix/spinnaker/orca/mine/tasks/RegisterCanaryTaskTest.java:22: error: package org.assertj.core.api does not exist
import static org.assertj.core.api.Assertions.assertThatThrownBy;
                                  ^

/orca/orca-mine/src/test/java/com/netflix/spinnaker/orca/mine/tasks/RegisterCanaryTaskTest.java:150: error: cannot find symbol
    assertThatThrownBy(() -> registerCanaryTask.execute(deployCanaryStage))
    ^
  symbol:   method assertThatThrownBy(()->regist[...]tage))
  location: class RegisterCanaryTaskTest

To fix this issue added assertj-core dependency explicitly.

…amework upgrade to 2.2-groovy-3.0

While upgrading spockframework from 2.0-groovy-3.0 to 2.2-groovy-3.0, encountered below errors during test execution of orca-mine module:
```
/orca/orca-mine/src/test/java/com/netflix/spinnaker/orca/mine/tasks/RegisterCanaryTaskTest.java:22: error: package org.assertj.core.api does not exist
import static org.assertj.core.api.Assertions.assertThatThrownBy;
                                  ^

/orca/orca-mine/src/test/java/com/netflix/spinnaker/orca/mine/tasks/RegisterCanaryTaskTest.java:150: error: cannot find symbol
    assertThatThrownBy(() -> registerCanaryTask.execute(deployCanaryStage))
    ^
  symbol:   method assertThatThrownBy(()->regist[...]tage))
  location: class RegisterCanaryTaskTest
```
To fix this issue added assertj-core dependency explicitly.
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Aug 2, 2024
@j-sandy
Copy link
Contributor Author

j-sandy commented Aug 2, 2024

$ ./gradlew orca-mine:dI --dependency assertj-core --configuration testCompileClasspath

> Task :orca-mine:dependencyInsight
org.assertj:assertj-core:3.22.0
  Variant compile:
    | Attribute Name                 | Provided | Requested         |
    |--------------------------------|----------|-------------------|
    | org.gradle.status              | release  |                   |
    | org.gradle.category            | library  | library           |
    | org.gradle.libraryelements     | jar      | classes+resources |
    | org.gradle.usage               | java-api | java-api          |
    | org.gradle.dependency.bundling |          | external          |
    | org.gradle.jvm.environment     |          | standard-jvm      |
    | org.gradle.jvm.version         |          | 11                |
   Selection reasons:
      - By constraint
      - Forced

org.assertj:assertj-core:3.22.0
\--- io.spinnaker.kork:kork-bom:7.236.0
     \--- testCompileClasspath

org.assertj:assertj-core:3.23.1 -> 3.22.0
\--- org.junit.platform:junit-platform-testkit:1.9.0
     +--- io.spinnaker.kork:kork-bom:7.236.0
     |    \--- testCompileClasspath
     +--- org.spockframework:spock-core:2.0-groovy-3.0 (requested org.junit.platform:junit-platform-testkit)
     |    +--- testCompileClasspath (requested org.spockframework:spock-core)
     |    \--- io.spinnaker.kork:kork-bom:7.236.0 (*)
     \--- org.junit:junit-bom:5.9.0
          +--- org.spockframework:spock-core:2.0-groovy-3.0 (requested org.junit:junit-bom:5.7.2) (*)
          +--- org.junit.jupiter:junit-jupiter-api:5.9.0
          |    +--- io.spinnaker.kork:kork-bom:7.236.0 (*)
          |    +--- org.junit:junit-bom:5.9.0 (*)
          |    \--- org.junit.jupiter:junit-jupiter-params:5.9.0
          |         +--- testCompileClasspath (requested org.junit.jupiter:junit-jupiter-params)
          |         +--- io.spinnaker.kork:kork-bom:7.236.0 (*)
          |         \--- org.junit:junit-bom:5.9.0 (*)
          +--- org.junit.platform:junit-platform-testkit:1.9.0 (*)
          +--- org.junit.platform:junit-platform-launcher:1.9.0
          |    +--- io.spinnaker.kork:kork-bom:7.236.0 (*)
          |    +--- org.junit.platform:junit-platform-testkit:1.9.0 (*)
          |    \--- org.junit:junit-bom:5.9.0 (*)
          +--- org.junit.platform:junit-platform-engine:1.9.0
          |    +--- io.spinnaker.kork:kork-bom:7.236.0 (*)
          |    +--- org.spockframework:spock-core:2.0-groovy-3.0 (requested org.junit.platform:junit-platform-engine) (*)
          |    +--- org.junit.platform:junit-platform-launcher:1.9.0 (*)
          |    \--- org.junit:junit-bom:5.9.0 (*)
          +--- org.junit.platform:junit-platform-commons:1.9.0
          |    +--- io.spinnaker.kork:kork-bom:7.236.0 (*)
          |    +--- org.junit.jupiter:junit-jupiter-api:5.9.0 (*)
          |    +--- org.junit.platform:junit-platform-engine:1.9.0 (*)
          |    \--- org.junit:junit-bom:5.9.0 (*)
          \--- org.junit.jupiter:junit-jupiter-params:5.9.0 (*)

@mergify mergify bot added the auto merged Merged automatically by a bot label Aug 2, 2024
@mergify mergify bot merged commit 3db7078 into spinnaker:master Aug 2, 2024
5 checks passed
@j-sandy j-sandy deleted the add-assertj branch August 5, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.35
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants