Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add filtering logic for stream data and constraint setuptools version #496

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Jul 27, 2024

@dalthviz dalthviz self-assigned this Jul 27, 2024
@dalthviz dalthviz force-pushed the spyder_22181 branch 3 times, most recently from af8a6a3 to 76ea2df Compare July 29, 2024 21:52
@dalthviz dalthviz changed the title [WIP] PR: Add filtering logic for stream data PR: Add filtering logic for stream data Jul 29, 2024
@dalthviz dalthviz changed the title PR: Add filtering logic for stream data PR: Add filtering logic for stream data and constraint setuptools version Jul 29, 2024
@dalthviz dalthviz marked this pull request as ready for review July 29, 2024 22:09
@dalthviz dalthviz requested a review from ccordoba12 July 29, 2024 22:11
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion for you, otherwise looks good to me.

spyder_kernels/console/outstream.py Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to the v3.0.0b8 milestone Jul 30, 2024
@ccordoba12
Copy link
Member

@dalthviz, please open a PR on the Spyder side to run our tests there with this PR. That way we'll be sure that this doesn't break anything there.

That's described in our Maintenance guide (see second to last bullet point).

@ccordoba12 ccordoba12 added the type:Bug Something isn't working label Jul 30, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 782fddc into spyder-ide:master Jul 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants