Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add service to handle the remote filesystem #11

Merged
merged 25 commits into from
Jan 22, 2025

Conversation

hlouzada
Copy link
Collaborator

Provide a remote backend for fsspec api using http rest and websockets.

@hlouzada hlouzada changed the title PR: Add remote-files system backend [WIP] PR: Add remote-files system backend Dec 30, 2024
@hlouzada hlouzada force-pushed the feat/remote-file-service branch from e2f920d to 83bfb48 Compare January 18, 2025 14:39
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hlouzada, this is a quick review for you to make the code easier to understand and follow in the future.

spyder_remote_services/__init__.py Outdated Show resolved Hide resolved
spyder_remote_services/services/__init__.py Outdated Show resolved Hide resolved
spyder_remote_services/services/fsspec/__init__.py Outdated Show resolved Hide resolved
spyder_remote_services/services/fsspec/handlers.py Outdated Show resolved Hide resolved
spyder_remote_services/services/fsspec/handlers.py Outdated Show resolved Hide resolved
spyder_remote_services/services/fsspec/mixin.py Outdated Show resolved Hide resolved
spyder_remote_services/services/fsspec/mixin.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 added the enhancement New feature or request label Jan 19, 2025
@ccordoba12 ccordoba12 changed the title [WIP] PR: Add remote-files system backend [WIP] PR: Add service to handle the remote filesystem Jan 19, 2025
@hlouzada hlouzada marked this pull request as ready for review January 21, 2025 13:54
@hlouzada hlouzada changed the title [WIP] PR: Add service to handle the remote filesystem PR: Add service to handle the remote filesystem Jan 21, 2025
@hlouzada hlouzada requested a review from ccordoba12 January 21, 2025 15:19
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hlouzada, last suggestions for you, then this should be ready.

spyder_remote_services/services/files/handlers.py Outdated Show resolved Hide resolved
spyder_remote_services/services/files/base.py Outdated Show resolved Hide resolved
spyder_remote_services/services/files/base.py Outdated Show resolved Hide resolved
spyder_remote_services/services/files/base.py Outdated Show resolved Hide resolved
spyder_remote_services/services/files/base.py Outdated Show resolved Hide resolved
spyder_remote_services/services/files/handlers.py Outdated Show resolved Hide resolved
spyder_remote_services/services/files/handlers.py Outdated Show resolved Hide resolved
spyder_remote_services/services/files/handlers.py Outdated Show resolved Hide resolved
spyder_remote_services/services/files/handlers.py Outdated Show resolved Hide resolved
spyder_remote_services/services/files/handlers.py Outdated Show resolved Hide resolved
@hlouzada hlouzada requested a review from ccordoba12 January 21, 2025 19:09
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the last commit introduced an error and an unnecessary blank.

spyder_remote_services/services/files/base.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @hlouzada!

@hlouzada hlouzada merged commit 2b8dcf2 into main Jan 22, 2025
@hlouzada hlouzada deleted the feat/remote-file-service branch January 22, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants