Add an all-checks capstone shard to CI
#779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/re-actors/alls-green One shard requires that all the others are green or skipped. This single shard can be added as a required check in GitHub's branch protection rules, then never touched again. When adding a new shard to the workflow, you just add its name to the "needs" list and you're done. And yes, it supports matrix strategies without needing to maintain a list of all the permutations.
RBusarow
force-pushed
the
rick/all-checks-shard
branch
from
16cfd8c
to
26bf28f
Compare
JoelWilcox
approved these changes
Nov 20, 2023
Comment on lines
+294
to
+297
| - name: require that all other jobs have passed | ||
| uses: re-actors/alls-green@release/v1 | ||
| with: | ||
| allowed-skips: publish-snapshot |
There was a problem hiding this comment.
Nice, I love that this is explicit. I was about to leave a comment on how we handle skips before seeing it 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/re-actors/alls-green
One shard requires that all the others are green or skipped. This single shard can be added as a required check in GitHub's branch protection rules, then never touched again. When adding a new shard to the workflow, you just add its name to the "needs" list and you're done.
And yes, it supports matrix strategies without needing to maintain a list of all the permutations.