Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an all-checks capstone shard to CI #779

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Add an all-checks capstone shard to CI #779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ jobs :
name : test-results-${{ matrix.kotlin-version }}
path : ./**/build/reports/tests/


test-windows :
runs-on : windows-latest
timeout-minutes : 25
Expand Down Expand Up @@ -274,3 +273,26 @@ jobs :

- name : "Build Benchmark Project"
run : ./gradlew :benchmark:app:assemble

all-checks:
if: always()
runs-on: ubuntu-latest
needs:
- test-ubuntu
- test-windows
- ktlint
- lint
- publish-maven-local
- publish-snapshot
- test-gradle-plugin
- kapt-for-dagger-factories
- instrumentation-tests
- gradle-wrapper-validation
- build-benchmark-project

steps:
- name: require that all other jobs have passed
uses: re-actors/alls-green@release/v1
with:
allowed-skips: publish-snapshot
Comment on lines +294 to +297
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I love that this is explicit. I was about to leave a comment on how we handle skips before seeing it 😁

jobs: ${{ toJSON(needs) }}