Skip to content

Commit

Permalink
fix: revert frozenlist changes
Browse files Browse the repository at this point in the history
There was a problem with the frozenlist package, which didn't had its packages added to wheels (aio-libs/frozenlist#342). The packages are now added, so the fix for this can be reverted, except for the pytest job which is the only one building on a debian image (faster runtime). Here the yarl and multidict packages still have the same problem as frozenlist had. Waiting fo a fix here.
  • Loading branch information
phbelitz committed Dec 2, 2022
1 parent ba35976 commit 00b6d2a
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion .github/actions/safety/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ runs:
steps:
- name: Install packages
run: |
apt update && apt install gcc build-essential -y
pip3 install --upgrade pip
pip3 install -r requirements_dev.txt
shell: sh
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/cicd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ jobs:
- name: Install packages
# Since we run inside an alpine based container, we cannot compile yarl and multidic
run: |
apk add gcc libc-dev
pip3 install --upgrade pip
YARL_NO_EXTENSIONS=1 MULTIDICT_NO_EXTENSIONS=1 pip3 install -r requirements_dev.txt
- name: Lint
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ COPY requirements.txt /requirements.txt

# Have to upgrade pip and install extra packages due to error when installing frozenlist
# Since we run inside an alpine based container, we cannot compile yarl and multidict
RUN apk add --no-cache gcc~=11.2.1_git20220219-r2 libc-dev~=0.7.2-r3 \
RUN apk add --no-cache \
&& pip install --no-cache-dir --upgrade pip~=22.3 \
&& YARL_NO_EXTENSIONS=1 MULTIDICT_NO_EXTENSIONS=1 pip install --no-cache-dir --prefix=/install -r /requirements.txt

Expand Down

0 comments on commit 00b6d2a

Please sign in to comment.