-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle image references with both a tag and digest present #763
fix: handle image references with both a tag and digest present #763
Conversation
Draft as long as there is no consensus on whether or not this is actually the right approach in #749 |
ca3e612
to
67015b0
Compare
4be238b
to
588665c
Compare
@richgerrard with this the tag is preserved and should be visible in the k8s pod description. additionally, what might be possible to do is add the tag and digest as annotations to the mutated resource. that might be more convenient to get information about the resource, without the need to do additional parsing. is that something you deem as useful? |
384aaca
to
7342024
Compare
Codecov ReportBase: 96.90% // Head: 96.94% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #763 +/- ##
===========================================
+ Coverage 96.90% 96.94% +0.04%
===========================================
Files 22 22
Lines 1226 1244 +18
===========================================
+ Hits 1188 1206 +18
Misses 38 38
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
5ed6c9b
to
9d83f0e
Compare
d78dfa6
to
df37c94
Compare
With this change, Connaisseur now supports the use of tags and digests simultaneously. The signature is still validated based on the digest, but the human readable aspect of the tag isn't lost.
df37c94
to
420fb36
Compare
Fixes #749
Description
It is possible for image references to contain both a tag and a digest at the same time. Previously, this was not handled causing the validators to fail.
I'm not sure if what I did is the most idiomatic or even elegant Python, but the changes are at least fairly small.
I've built and pushed the image as
ghcr.io/chgl/connaisseur:fix-image-tag-and-digest
and testet it using the helm chart by settingThe images that were previously causing issues were now correctly validated and accepted.
Checklist
develop
values.yaml
andChart.yaml
(if necessary)