Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add proper startup, liveness and readiness probes #273

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Add proper startup, liveness and readiness probes #273

wants to merge 2 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 21, 2022 •
edited
Loading

Description

For #142
It would be very good if you could check the druid docs to make sure if not miss-understood the checks or if you have a better idea

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer requested review from fhennig, adwk67 and a team July 21, 2022 12:54
@sbernauer sbernauer changed the title Add prober startup, liveness and readiness probes Add proper startup, liveness and readiness probes Jul 21, 2022
maltesander
maltesander approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked the docs and think you got it right :)

@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 22, 2022
@sbernauer
Add proper startup, liveness and readiness probes (#273)
1f2e9a9 
# Description

For #142
It would be very good if you could check the druid docs to make sure if not miss-understood the checks or if you have a better idea
@bors
Copy link
Contributor

bors bot commented Jul 22, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add proper startup, liveness and readiness probes [Merged by Bors] - Add proper startup, liveness and readiness probes Jul 22, 2022
@bors bors bot closed this Jul 22, 2022
@bors bors bot deleted the probes branch July 22, 2022 06:43
@sbernauer sbernauer mentioned this pull request Jul 22, 2022
Open
@adwk67
Copy link
Member

adwk67 commented Jul 22, 2022

Sorry, was a bit late to this. Just to add that an extra motivation behind this, IIRC, was to avoid a lot of the error logging in the tests. Am running the tests locally now and the output is a lot cleaner. Nice job!

@sbernauer
Copy link
Member Author

Awesome, thx! Sorry for the merging so fast ^^

sbernauer added a commit that referenced this pull request Jul 27, 2022
@sbernauer
Revert "Add proper startup, liveness and readiness probes (#273)"
cc6902d 
This reverts commit 1f2e9a9.

The probes caused test failures when the opa authorizer was used.
See #275 for details.
bors bot pushed a commit that referenced this pull request Jul 27, 2022
@sbernauer
Revert "Add proper startup, liveness and readiness probes (#273)" (#276)
f9511bf 
This reverts commit 1f2e9a9.

The probes caused test failures when the opa authorizer was used.
See #275 for details.
@lfrancke lfrancke linked an issue Aug 12, 2022 that may be closed by this pull request
Add correct probes to Druid containers #142
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

@fhennig fhennig Awaiting requested review from fhennig

@adwk67 adwk67 Awaiting requested review from adwk67

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add correct probes to Druid containers
3 participants
@sbernauer @adwk67 @maltesander