-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add stackable-versioned
and k8s-version
crates for CRD versioning
#764
Conversation
I see that this is still a draft, but I already want to encourage the use of more comments in the code, especially more module-level comments like "This module is used for .. and called by ..." to make it easier to grasp the overall setup of the crate for someone that isn't familiar with it. |
I usually wait till the last second to add (doc) comments to my code. I do this, because there is a high chance that code will change until the PR is merge-able and thus I want to avoid rewriting the comments over and over again. So don't worry, there will be plenty of comments when this gets merged :) |
This crate enables parsing of Kubernetes API versions from strings into well-defined structs with support for ordering and equality checking.
This adds support for darling's FromMeta trait, which enables implementors to be constructed from macro attributes.
This PR now implements the basic code to generate a very basic versioned field. There are a bunch of improvements we need in there, but I would like to merge the PR as is, and then introduce missing features / improvements in follow-up PRs, as this PR is already quite big. Some items we need to tackle are:
I'll add a few more comments before moving this PR into "Ready for Review". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
Co-authored-by: Nick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Part of stackabletech/issues#507 (refinement)
Tasks
Reviewer