Skip to content

feat(stackable-versioned): Improve action chain generation #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 22, 2024
Merged

feat(stackable-versioned): Improve action chain generation #784

merged 16 commits into from
May 22, 2024

Conversation

@Techassi
Copy link
Member

Description

Tracked by stackabletech/issues#507, follow-up of #764

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

@Techassi Techassi self-assigned this May 10, 2024
@Techassi Techassi mentioned this pull request May 10, 2024
Merged
@Techassi Techassi marked this pull request as ready for review May 21, 2024 11:01
@Techassi Techassi requested a review from NickLarsenNZ May 21, 2024 11:01
@Techassi Techassi mentioned this pull request May 21, 2024
Merged
sbernauer
sbernauer requested changes May 22, 2024
View reviewed changes
@Techassi Techassi requested a review from sbernauer May 22, 2024 13:00
sbernauer
sbernauer approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM that we address the discussion #784 (comment) later on

@Techassi Techassi added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 3548b01 May 22, 2024
@Techassi Techassi deleted the feat/crd-versioning-chain branch May 22, 2024 13:22
@Techassi Techassi mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

@NickLarsenNZ NickLarsenNZ Awaiting requested review from NickLarsenNZ

Assignees

@Techassi Techassi

Labels

type/feature-improvement

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Techassi @sbernauer