fix(react): file tree's files to indicate selected state #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AriPerkkio
commented
Aug 20, 2024
| return ( | ||
| <button | ||
| className={`flex items-center gap-2 w-full pr-2 border-2 border-transparent text-faded ${className ?? ''}`} | ||
| style={{ paddingLeft: `${12 + depth * NODE_PADDING_LEFT}px` }} | ||
| onClick={() => onClick?.()} | ||
| aria-pressed={ariaPressed === true ? 'true' : undefined} |
There was a problem hiding this comment.
This isn't 100% correct either as these are not toggle buttons, but it's better than nothing. Proper way would be to throw these buttons away and create a proper tree: https://www.w3.org/WAI/ARIA/apg/patterns/treeview/
There was a problem hiding this comment.
The current representation though is much more efficient and much simpler than a tree.
There was a problem hiding this comment.
Simpler sure, but not accessible as it's not semantic. Assistive technologies are unable to detect these as file trees - it's just multiple buttons, not even a list. If we some day want to make this accessible, we should check how vscode.dev for example does this.
Nemikolh
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds attribute to file element's
button's so that it can be seen which file is currently selected/active.