Skip to content

fix(react): file tree's files to indicate selected state #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix(react): file tree's files to indicate selected state #268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
798a5df
fix(react): file tree's files to indicate selected state
AriPerkkio Aug 15, 2024
df7b410
Merge branch 'main' into fix/file-tree-selected-file
AriPerkkio Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/components/react/src/core/FileTree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ function File({ file: { depth, name }, onClick, selected }: FileProps) {
'text-tk-elements-fileTree-file-iconColorSelected': selected,
})}
onClick={onClick}
aria-pressed={selected}
>
{name}
</NodeButton>
Expand All @@ -162,14 +163,16 @@ interface ButtonProps {
children: ReactNode;
className?: string;
onClick?: () => void;
'aria-pressed'?: boolean;
}

function NodeButton({ depth, iconClasses, onClick, className, children }: ButtonProps) {
function NodeButton({ depth, iconClasses, onClick, className, 'aria-pressed': ariaPressed, children }: ButtonProps) {
return (
<button
className={`flex items-center gap-2 w-full pr-2 border-2 border-transparent text-faded ${className ?? ''}`}
style={{ paddingLeft: `${12 + depth * NODE_PADDING_LEFT}px` }}
onClick={() => onClick?.()}
aria-pressed={ariaPressed === true ? 'true' : undefined}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't 100% correct either as these are not toggle buttons, but it's better than nothing. Proper way would be to throw these buttons away and create a proper tree: https://www.w3.org/WAI/ARIA/apg/patterns/treeview/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current representation though is much more efficient and much simpler than a tree.

Copy link
Member Author

@AriPerkkio AriPerkkio Aug 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler sure, but not accessible as it's not semantic. Assistive technologies are unable to detect these as file trees - it's just multiple buttons, not even a list. If we some day want to make this accessible, we should check how vscode.dev for example does this.

image

>
<div className={classNames('scale-120 shrink-0', iconClasses)}></div>
<span>{children}</span>
Expand Down