Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rtools43 in CI #2947

Closed
wants to merge 1 commit into from
Closed

Update to rtools43 in CI #2947

wants to merge 1 commit into from

Conversation

andrjohns
Copy link
Collaborator

Summary

Our GHA CI for running Windows headers/tests is using RTools40. Given that the current R version is 4.3, we should be testing using RTools43.

This PR updates our CI to use RTools43, following the installation instructions in the manual: https://mc-stan.org/docs/cmdstan-guide/cmdstan-installation.html#rtools42-rtools43

Tests

N/A - current tests should still pass

Side Effects

N/A

Release notes

Update CI to use RTools43

Checklist

  • Math issue #(issue number)

  • Copyright holder: Andrew Johnson

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@andrjohns
Copy link
Collaborator Author

Closing for some debugging

@andrjohns andrjohns closed this Oct 2, 2023
@WardBrian WardBrian mentioned this pull request Oct 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants