Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ROS Noetic #371

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix for ROS Noetic #371

wants to merge 8 commits into from

Conversation

kirohy
Copy link
Contributor

@kirohy kirohy commented Apr 8, 2024

  • add choreonoid_noetic.patch for building choreonoid-1.7 in Noetic
  • apply 2to3 on python scripts

These changes will enable to build and run choreonoid samples in hrpsys_choreonoid_tutorials/launch.

@kirohy kirohy marked this pull request as ready for review June 13, 2024 05:59
@kirohy kirohy changed the title [WIP] Fix for ROS Noetic Fix for ROS Noetic Jun 13, 2024
@@ -46,7 +46,7 @@ def parse_filename(filestr):
pkgname = ret.group(1)
#packagepath = commands.getoutput('rospack find %s'%(pkgname))
packagepath = subprocess.check_output(['rospack', 'find', pkgname])
packagepath = packagepath.rstrip('\n')
packagepath = packagepath.decode().rstrip('\n')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed this works on python2 too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script failed to run in melodic. I'll make it compatible with both ros version

- <depend>python</depend>
- <depend>python-numpy</depend>
+ <!-- <depend>python</depend> -->
+ <!-- <depend>python-numpy</depend> -->
Copy link
Member

@k-okada k-okada Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-okada
Copy link
Member

k-okada commented Jun 13, 2024

@kirohy are

-option(ENABLE_CORBA "Enable CORBA related modules / plugins" OFF)
+# option(ENABLE_CORBA "Enable CORBA related modules / plugins" OFF)
+option(ENABLE_CORBA "Enable CORBA related modules / plugins" ON)
+option(BUILD_CORBA_PLUGIN "Build CORBA Plugin" ON)

related to Noetic support?

@kirohy
Copy link
Contributor Author

kirohy commented Jun 13, 2024

No. Noetic patch is based on https://github.com/start-jsk/rtmros_choreonoid/blob/master/choreonoid.patch, and only python options are changed from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants