-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for ROS Noetic #371
Open
kirohy
wants to merge
8
commits into
start-jsk:master
Choose a base branch
from
kirohy:fix_20.04
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix for ROS Noetic #371
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
97356ed
add choreonoid_noetic.patch for choreonoid-1.7 in Noetic
kirohy fc46362
apply 2to3 -f filter
kirohy 9729883
apply 2to3 -f print
kirohy 16585aa
apply 2to3 -f dict
kirohy ad0a10c
apply 2to3 -f basestring
kirohy 0a36c50
apply 2to3 -f except
kirohy 509f3f6
fix str problem in python3
kirohy 0554666
python2, python3 compatible
kirohy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,114 @@ | ||
diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
index 504d56c7..8f22b7cc 100644 | ||
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -1,5 +1,6 @@ | ||
cmake_minimum_required(VERSION 3.1.0) # Qt5 requies this version or later | ||
|
||
+ | ||
cmake_policy(SET CMP0003 NEW) | ||
cmake_policy(SET CMP0057 NEW) | ||
set(CMAKE_ALLOW_LOOSE_LOOP_CONSTRUCTS true) | ||
@@ -648,7 +649,9 @@ if(MSVC) | ||
endif() | ||
|
||
# CORBA, omniORB | ||
-option(ENABLE_CORBA "Enable CORBA related modules / plugins" OFF) | ||
+# option(ENABLE_CORBA "Enable CORBA related modules / plugins" OFF) | ||
+option(ENABLE_CORBA "Enable CORBA related modules / plugins" ON) | ||
+option(BUILD_CORBA_PLUGIN "Build CORBA Plugin" ON) | ||
|
||
if(ENABLE_CORBA) | ||
# The OMNIDYNAMIC_XXX variables are used for storing the omniORB information | ||
@@ -904,6 +907,9 @@ if(ENABLE_CORBA) | ||
endif(ENABLE_CORBA) | ||
|
||
# OpenRTM | ||
+# option(BUILD_OPENRTM_PLUGIN "Building OpenRTMPlugin" OFF) | ||
+option(BUILD_OPENRTM_PLUGIN "Building OpenRTMPlugin" ON) | ||
+ | ||
if(BUILD_OPENRTM_PLUGIN) | ||
find_package(OpenRTM REQUIRED CONFIG) | ||
|
||
@@ -912,7 +918,7 @@ if(BUILD_OPENRTM_PLUGIN) | ||
list(APPEND OPENRTM_DEFINITIONS -DOPENRTM_VERSION12) | ||
list(APPEND OPENRTM_DEFINITIONS -Wno-deprecated) | ||
|
||
- elseif(OPENRTM_VERSION VERSION_EQUAL "1.1.2") | ||
+ elseif(OPENRTM_VERSION VERSION_EQUAL "1.1.2" OR OPENRTM_VERSION STREQUAL "1.1.0") | ||
list(APPEND OPENRTM_DEFINITIONS -DOPENRTM_VERSION11) | ||
# Remove extra "-I" from the elements of OPENRTM_INCLUDE_DIRS | ||
unset(include_dirs) | ||
@@ -935,7 +941,8 @@ if(BUILD_OPENRTM_PLUGIN) | ||
|
||
set(IDL_INCLUDE_DIRS ${IDL_INCLUDE_DIRS} ${OPENRTM_INCLUDE_DIRS}) | ||
|
||
- option(USE_BUILTIN_CAMERA_IMAGE_IDL "Enable this option when you run hrpsys-base on Choreonoid" OFF) | ||
+ # option(USE_BUILTIN_CAMERA_IMAGE_IDL "Enable this option when you run hrpsys-base on Choreonoid" OFF) | ||
+ option(USE_BUILTIN_CAMERA_IMAGE_IDL "Enable this option when you run hrpsys-base on Choreonoid" ON) | ||
if(USE_BUILTIN_CAMERA_IMAGE_IDL) | ||
list(APPEND OPENRTM_DEFINITIONS -DUSE_BUILTIN_CAMERA_IMAGE_IDL) | ||
else() | ||
diff --git a/package.xml b/package.xml | ||
index 5e1e1e32..a4cc62a4 100644 | ||
--- a/package.xml | ||
+++ b/package.xml | ||
@@ -23,8 +23,9 @@ | ||
<exec_depend>yaml</exec_depend> | ||
<depend>zlib</depend> | ||
<depend>libjpeg</depend> | ||
- <build_depend>libpng12-dev</build_depend> | ||
+ <build_depend>libpng-dev</build_depend> | ||
<build_depend>assimp-dev</build_depend> | ||
+ <build_depend>openrtm_aist</build_depend> | ||
<exec_depend>assimp</exec_depend> | ||
|
||
<build_export_depend>qtbast5-dev</build_export_depend> | ||
@@ -37,8 +38,8 @@ | ||
<exec_depend>libqt5-opengl</exec_depend> | ||
<exec_depend>opengl</exec_depend> | ||
|
||
- <depend>python</depend> | ||
- <depend>python-numpy</depend> | ||
+ <!-- <depend>python</depend> --> | ||
+ <!-- <depend>python-numpy</depend> --> | ||
|
||
<build_depend>libpulse-dev</build_depend> | ||
<build_depend>libsndfile1-dev</build_depend> | ||
diff --git a/sample/SpringModel/CMakeLists.txt b/sample/SpringModel/CMakeLists.txt | ||
index b855a2e9..37fbd57a 100644 | ||
--- a/sample/SpringModel/CMakeLists.txt | ||
+++ b/sample/SpringModel/CMakeLists.txt | ||
@@ -2,7 +2,8 @@ if(NOT ENABLE_GUI) | ||
return() | ||
endif() | ||
|
||
-option(BUILD_SPRING_MODEL_SAMPLE "Building a spring model sample" OFF) | ||
+# option(BUILD_SPRING_MODEL_SAMPLE "Building a spring model sample" OFF) | ||
+option(BUILD_SPRING_MODEL_SAMPLE "Building a spring model sample" ON) | ||
if(NOT BUILD_SPRING_MODEL_SAMPLE) | ||
return() | ||
endif() | ||
diff --git a/src/CorbaPlugin/CMakeLists.txt b/src/CorbaPlugin/CMakeLists.txt | ||
index 4b39461b..5d42d51d 100644 | ||
--- a/src/CorbaPlugin/CMakeLists.txt | ||
+++ b/src/CorbaPlugin/CMakeLists.txt | ||
@@ -2,7 +2,8 @@ | ||
|
||
#set(CMAKE_BUILD_TYPE Debug) | ||
|
||
-option(BUILD_CORBA_PLUGIN "Build CORBA Plugin" OFF) | ||
+# option(BUILD_CORBA_PLUGIN "Build CORBA Plugin" OFF) | ||
+option(BUILD_CORBA_PLUGIN "Build CORBA Plugin" ON) | ||
|
||
if(NOT BUILD_CORBA_PLUGIN) | ||
return() | ||
diff --git a/src/OpenRTM/CMakeLists.txt b/src/OpenRTM/CMakeLists.txt | ||
index 7771c260..ac5fcdc8 100644 | ||
--- a/src/OpenRTM/CMakeLists.txt | ||
+++ b/src/OpenRTM/CMakeLists.txt | ||
@@ -1,4 +1,3 @@ | ||
-option(BUILD_OPENRTM_PLUGIN "Building OpenRTMPlugin" OFF) | ||
if(NOT BUILD_OPENRTM_PLUGIN) | ||
return() | ||
elseif(NOT (ENABLE_CORBA AND BUILD_CORBA_PLUGIN)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,7 +46,7 @@ def parse_filename(filestr): | |
pkgname = ret.group(1) | ||
#packagepath = commands.getoutput('rospack find %s'%(pkgname)) | ||
packagepath = subprocess.check_output(['rospack', 'find', pkgname]) | ||
packagepath = packagepath.rstrip('\n') | ||
packagepath = packagepath.decode().rstrip('\n') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. confirmed this works on python2 too There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This script failed to run in melodic. I'll make it compatible with both ros version |
||
filestr = filestr[:ret.start(0)] + packagepath + filestr[ret.end(0):] | ||
|
||
return filestr | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use ROS_PYTHON_VERSION https://answers.ros.org/question/363076/how-to-write-a-packagexml-compatible-with-both-of-melodic-and-noetic-when-it-depends-python-library-name-package/