Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature (ci): Add srcds/cs2 support #153

Conversation

joeltimothyoh
Copy link
Member

@joeltimothyoh joeltimothyoh commented Nov 10, 2023

  • Bump base image in build/Dockerfile to startersclan/steamcmd:git-20231109.0.0
  • Add custom build and test steps for srcds/cs2
  • Add working command-line and docker-compose examples
  • Update documentation on srcds/cs2

@joeltimothyoh joeltimothyoh added this to the next-release milestone Nov 10, 2023
@joeltimothyoh joeltimothyoh self-assigned this Nov 10, 2023
@joeltimothyoh joeltimothyoh force-pushed the feature/ci-add-srcds-cs2-support branch 5 times, most recently from 82da274 to 7d6061c Compare November 10, 2023 13:02
update/Dockerfile Show resolved Hide resolved
build.sh Show resolved Hide resolved
.github/workflows/ci-master-pr.yml Show resolved Hide resolved
@joeltimothyoh joeltimothyoh force-pushed the feature/ci-add-srcds-cs2-support branch 5 times, most recently from b6378a7 to 5abfd02 Compare November 10, 2023 14:55
@leojonathanoh leojonathanoh force-pushed the feature/ci-add-srcds-cs2-support branch 2 times, most recently from a069484 to b6601b2 Compare November 10, 2023 19:52
build.sh Outdated Show resolved Hide resolved
@joeltimothyoh joeltimothyoh force-pushed the feature/ci-add-srcds-cs2-support branch from 9bcd642 to dd589f4 Compare November 11, 2023 04:33
build.sh Outdated Show resolved Hide resolved
Copy link
Member

@leojonathanoh leojonathanoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joeltimothyoh joeltimothyoh force-pushed the feature/ci-add-srcds-cs2-support branch 2 times, most recently from 1306bfd to 8aedd70 Compare November 11, 2023 15:21
- Bump base image in `build/Dockerfile` to `startersclan/steamcmd:git-20231109.0.0`
- Add custom `build` and `test` steps for `srcds/cs2`
- Add working command-line and `docker-compose` examples
- Update documentation on `srcds/cs2`

Co-authored-by: Leonard Jonathan Oh <[email protected]>
@joeltimothyoh joeltimothyoh force-pushed the feature/ci-add-srcds-cs2-support branch from 8aedd70 to 85a2e8f Compare November 11, 2023 15:27
@joeltimothyoh joeltimothyoh merged commit 4505271 into startersclan:master Nov 11, 2023
7 checks passed
leojonathanoh added a commit to leojonathanoh/docker-sourceservers that referenced this pull request Nov 11, 2023
leojonathanoh added a commit to leojonathanoh/docker-sourceservers that referenced this pull request Nov 11, 2023
leojonathanoh added a commit that referenced this pull request Nov 11, 2023
leojonathanoh added a commit to leojonathanoh/docker-sourceservers that referenced this pull request Nov 16, 2023
Fixes regression in startersclan#153, where validation stopped working for `srcds/csgo`
joeltimothyoh pushed a commit to leojonathanoh/docker-sourceservers that referenced this pull request Nov 17, 2023
Fixes regression in startersclan#153, where validation stopped working for `srcds/csgo`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants