-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature (ci): Add srcds/cs2
support
#153
Merged
joeltimothyoh
merged 1 commit into
startersclan:master
from
joeltimothyoh:feature/ci-add-srcds-cs2-support
Nov 11, 2023
Merged
Feature (ci): Add srcds/cs2
support
#153
joeltimothyoh
merged 1 commit into
startersclan:master
from
joeltimothyoh:feature/ci-add-srcds-cs2-support
Nov 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeltimothyoh
force-pushed
the
feature/ci-add-srcds-cs2-support
branch
5 times, most recently
from
November 10, 2023 13:02
82da274
to
7d6061c
Compare
joeltimothyoh
force-pushed
the
feature/ci-add-srcds-cs2-support
branch
5 times, most recently
from
November 10, 2023 14:55
b6378a7
to
5abfd02
Compare
leojonathanoh
force-pushed
the
feature/ci-add-srcds-cs2-support
branch
2 times, most recently
from
November 10, 2023 19:52
a069484
to
b6601b2
Compare
joeltimothyoh
force-pushed
the
feature/ci-add-srcds-cs2-support
branch
from
November 11, 2023 04:33
9bcd642
to
dd589f4
Compare
leojonathanoh
approved these changes
Nov 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
joeltimothyoh
force-pushed
the
feature/ci-add-srcds-cs2-support
branch
2 times, most recently
from
November 11, 2023 15:21
1306bfd
to
8aedd70
Compare
- Bump base image in `build/Dockerfile` to `startersclan/steamcmd:git-20231109.0.0` - Add custom `build` and `test` steps for `srcds/cs2` - Add working command-line and `docker-compose` examples - Update documentation on `srcds/cs2` Co-authored-by: Leonard Jonathan Oh <[email protected]>
joeltimothyoh
force-pushed
the
feature/ci-add-srcds-cs2-support
branch
from
November 11, 2023 15:27
8aedd70
to
85a2e8f
Compare
leojonathanoh
added a commit
to leojonathanoh/docker-sourceservers
that referenced
this pull request
Nov 11, 2023
leojonathanoh
added a commit
to leojonathanoh/docker-sourceservers
that referenced
this pull request
Nov 11, 2023
leojonathanoh
added a commit
to leojonathanoh/docker-sourceservers
that referenced
this pull request
Nov 16, 2023
Fixes regression in startersclan#153, where validation stopped working for `srcds/csgo`
joeltimothyoh
pushed a commit
to leojonathanoh/docker-sourceservers
that referenced
this pull request
Nov 17, 2023
Fixes regression in startersclan#153, where validation stopped working for `srcds/csgo`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build/Dockerfile
tostartersclan/steamcmd:git-20231109.0.0
build
andtest
steps forsrcds/cs2
docker-compose
examplessrcds/cs2