fix(replies): fix replies from Status and to Status messages #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for status-im/status-desktop#16323 There were multiple problems. 1. The ParentID was not set correctly when a message was sent from Status 2. We didn't send back the ID of messages that we sent, so the gateway couldn't associate the new messages to the old ones 3. Missing param in the toml config `PreserveThreading` 4. Discord messages are weirdly formatted when a reply is send. It cannot use webhooks, so we need to pass the username directly in the message (it's ugly, but it works) Finally, there was an issue on the status-go side. We tried to use the discord message ID to find the replies, but the bridge already converts it to the right ID, so we could just use it directly
|
status-go PR status-im/status-go#5830 |
|
nice @jrainville : once the status-go PR is merged and cherry picked on release 2.30 branch we could use this PR to update the status-go version as well. |
Yeah we could. Though as far as I understand, the status-go changes are mostly useful for actual users receiving messages, so we'll need for 2.31 to have the real fix in the hands of users |
|
@jrainville : ah thanks for explaining! |
siddarthkay
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for status-im/status-desktop#16323
There were multiple problems.
PreserveThreadingFinally, there was an issue on the status-go side. We tried to use the discord message ID to find the replies, but the bridge already converts it to the right ID, so we could just use it directly
How it looks in Status:
How it looks in Discord:
They all work now. The only sad thing is replies from Status look a bit ugly in Discord, but that's a limitation in the Discord API I think.