Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replies): fix replies from Status and to Status messages #18

Merged
merged 1 commit into from
Sep 14, 2024

Commits on Sep 12, 2024

  1. fix(replies): fix replies from Status and to Status messages

    Needed for status-im/status-desktop#16323
    
    There were multiple problems.
    
    1. The ParentID was not set correctly when a message was sent from Status
    2. We didn't send back the ID of messages that we sent, so the gateway couldn't associate the new messages to the old ones
    3. Missing param in the toml config `PreserveThreading`
    4. Discord messages are weirdly formatted when a reply is send. It cannot use webhooks, so we need to pass the username directly in the message (it's ugly, but it works)
    
    Finally, there was an issue on the status-go side. We tried to use the discord message ID to find the replies, but the bridge already converts it to the right ID, so we could just use it directly
    jrainville committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e9643d2 View commit details
    Browse the repository at this point in the history