Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: fix sqlcipher build for android on ndkr26b #5844

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented Sep 18, 2024

Summary

This PR bumps the version of our fork of go-sqlcipher to obtain a fix for building status-go for android.
I observed that the builds started failing after I upgraded to NDK r26b.

related PR in go-sqlcipher repo : status-im/go-sqlcipher#2

needed for : status-im/status-mobile#21268

@status-im-auto
Copy link
Member

status-im-auto commented Sep 18, 2024

Jenkins Builds

Click to see older builds (5)
Commit #️⃣ Finished (UTC) Duration Platform Result
64fa736 #1 2024-09-18 02:23:18 ~2 min android 📄log
✔️ 64fa736 #1 2024-09-18 02:23:52 ~2 min tests-rpc 📄log
✔️ 64fa736 #1 2024-09-18 02:25:17 ~3 min linux 📦zip
✔️ 64fa736 #1 2024-09-18 02:26:32 ~5 min ios 📦zip
✔️ 64fa736 #1 2024-09-18 02:54:38 ~33 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b5c148c #2 2024-09-18 03:02:20 ~2 min tests-rpc 📄log
✔️ b5c148c #2 2024-09-18 03:02:51 ~2 min linux 📦zip
✔️ b5c148c #2 2024-09-18 03:03:49 ~3 min ios 📦zip
✔️ b5c148c #2 2024-09-18 03:04:29 ~4 min android 📦aar
✔️ b5c148c #2 2024-09-18 03:37:36 ~37 min tests 📄log
✔️ 9f6b2bb #3 2024-09-20 13:43:16 ~2 min tests-rpc 📄log
✔️ 9f6b2bb #3 2024-09-20 13:43:22 ~2 min linux 📦zip
✔️ 9f6b2bb #4 2024-09-20 13:45:47 ~2 min linux 📦zip
✔️ 9f6b2bb #4 2024-09-20 13:46:10 ~2 min tests-rpc 📄log
✔️ 9f6b2bb #4 2024-09-20 13:46:40 ~5 min ios 📦zip
✔️ 9f6b2bb #4 2024-09-20 13:47:05 ~6 min android 📦aar
✖️ 9f6b2bb #3 2024-09-20 14:13:26 ~32 min tests 📄log
✔️ 9f6b2bb #4 2024-09-20 14:46:23 ~32 min tests 📄log

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2758 2 2756 30
View the top 2 failed tests by shortest run time
github.com/status-im/status-go/peers TestPeerPoolSimulationSuite/TestMailServerPeersDiscovery
Stack Traces | 20s run time
=== RUN   TestPeerPoolSimulationSuite/TestMailServerPeersDiscovery
    peerpool_test.go:101: 
        	Error Trace:	.../status-go_prs_tests_PR-5844/peers/peerpool_test.go:101
        	            				.../status-go_prs_tests_PR-5844/peers/peerpool_test.go:378
        	Error:      	timed out waiting for a peer
        	Test:       	TestPeerPoolSimulationSuite/TestMailServerPeersDiscovery
    peerpool_test.go:379: 
        	Error Trace:	.../status-go_prs_tests_PR-5844/peers/peerpool_test.go:379
        	Error:      	Not equal: 
        	            	expected: "6af7eca59a1b1560592f3ddf7c961103ce6753e0ec9ba242054a0048b30b8437"
        	            	actual  : "0000000000000000000000000000000000000000000000000000000000000000"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-6af7eca59a1b1560592f3ddf7c961103ce6753e0ec9ba242054a0048b30b8437
        	            	+0000000000000000000000000000000000000000000000000000000000000000
        	Test:       	TestPeerPoolSimulationSuite/TestMailServerPeersDiscovery
    peerpool_test.go:112: 
        	Error Trace:	.../status-go_prs_tests_PR-5844/peers/peerpool_test.go:112
        	            				.../status-go_prs_tests_PR-5844/peers/peerpool_test.go:382
        	Error:      	timed out waiting a pool event
        	Test:       	TestPeerPoolSimulationSuite/TestMailServerPeersDiscovery
--- FAIL: TestPeerPoolSimulationSuite/TestMailServerPeersDiscovery (20.02s)

github.com/status-im/status-go/peers TestPeerPoolSimulationSuite
Stack Traces | 20s run time
=== RUN   TestPeerPoolSimulationSuite
--- FAIL: TestPeerPoolSimulationSuite (20.04s)


To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@siddarthkay siddarthkay force-pushed the fix-sqlcipher-for-ndk-r26b branch from b5c148c to 9e5cc60 Compare September 20, 2024 13:40
@siddarthkay siddarthkay force-pushed the fix-sqlcipher-for-ndk-r26b branch from 9e5cc60 to 9f6b2bb Compare September 20, 2024 13:40
@siddarthkay siddarthkay merged commit 4d22596 into develop Sep 22, 2024
11 checks passed
@siddarthkay siddarthkay deleted the fix-sqlcipher-for-ndk-r26b branch September 22, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants