-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore_: fix sqlcipher build for android on ndkr26b #5844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
requested review from
caybro,
alexjba,
igor-sirotin and
jakubgs
September 18, 2024 02:21
Jenkins BuildsClick to see older builds (5)
|
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
siddarthkay
force-pushed
the
fix-sqlcipher-for-ndk-r26b
branch
from
September 18, 2024 02:59
64fa736
to
b5c148c
Compare
13 tasks
caybro
approved these changes
Sep 18, 2024
jakubgs
approved these changes
Sep 19, 2024
siddarthkay
force-pushed
the
fix-sqlcipher-for-ndk-r26b
branch
from
September 20, 2024 13:40
b5c148c
to
9e5cc60
Compare
siddarthkay
force-pushed
the
fix-sqlcipher-for-ndk-r26b
branch
from
September 20, 2024 13:40
9e5cc60
to
9f6b2bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps the version of our fork of
go-sqlcipher
to obtain a fix for buildingstatus-go
forandroid
.I observed that the builds started failing after I upgraded to NDK
r26b
.related PR in
go-sqlcipher
repo : status-im/go-sqlcipher#2needed for : status-im/status-mobile#21268