upgrade react-native to 0.75.3 #21268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (112)
|
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
2 times, most recently
from
169d36e to
9539861
Compare
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
2 times, most recently
from
6a2ebae to
8abe656
Compare
siddarthkay
commented
Sep 18, 2024
| org.junit:junit-bom:5.9.3 | ||
| org.junit:junit-bom:5.9.2 | ||
| org.codehaus.mojo:animal-sniffer-annotations:1.23 | ||
| com.android.tools.lint:lint-gradle:31.5.0' \ |
There was a problem hiding this comment.
note to self : I need to try https://github.com/gradle/github-dependency-graph-gradle-plugin/tree/main#:~:text=Using%20the%20plugin%20to%20generate%20dependency%20reports as suggested by @mendelskiv93
There was a problem hiding this comment.
This shit is tragic and unsustainable...
siddarthkay
commented
Sep 18, 2024
siddarthkay
commented
Sep 18, 2024
siddarthkay
commented
Sep 18, 2024
siddarthkay
commented
Sep 18, 2024
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
0dced72 to
96d667e
Compare
siddarthkay
force-pushed
the
use-nixpkgs-unstable-gradle-8-8
branch
from
17180a0 to
9ed6679
Compare
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
96d667e to
e469409
Compare
siddarthkay
force-pushed
the
use-nixpkgs-unstable-gradle-8-8
branch
5 times, most recently
from
e64d894 to
3c5b671
Compare
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
e469409 to
307b76d
Compare
jakubgs
requested changes
Sep 26, 2024
| org.junit:junit-bom:5.9.3 | ||
| org.junit:junit-bom:5.9.2 | ||
| org.codehaus.mojo:animal-sniffer-annotations:1.23 | ||
| com.android.tools.lint:lint-gradle:31.5.0' \ |
There was a problem hiding this comment.
This shit is tragic and unsustainable...
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
2 times, most recently
from
4a62604 to
0070bfc
Compare
29% of end-end tests have passedNot executed tests (1)Failed tests (5)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Passed tests (2)Click to expandClass TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
|
29% of end-end tests have passedNot executed tests (1)Failed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Passed tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
|
We're keeping an eye, even when we are ignoring |
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
3 times, most recently
from
9c19c15 to
4d755a8
Compare
|
@siddarthkay, I did a quick check on this PR in an emulator to get a feeling of how it's going. Everything seemed to be rendered correctly to me. One problem: Nothing happens when pressing on certain views, such as the profile avatar to open the settings, pressing on tabs (not bottom tabs), pressing on the "invite friends to Status", pressing on the "Discover" communities button, etc, but some buttons/actions do work, like bottom sheets and their actions. Here is the logcat output right after pressing on these views: |
|
Thanks for checking this PR out @ilmotta, I too observed similar issues. |
We need to check, but it may also be related to usages of |
|
@ulisesmac : Thanks for the suggestion, indeed it was |
|
@siddarthkay We can't just move from Sometimes it works, but they work different.
What I want to say is that if we just swap, we might break styles in some areas (or if we are lucky, maybe nothing has been broken), but again, we need to confirm. I can check it on Monday and fix it if needed, if you wish. |
Thanks! I would appreciate that! |
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
061331d to
d7b0dda
Compare
75% of end-end tests have passedFailed tests (2)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (6)Click to expandClass TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
|
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
d7b0dda to
6f6c688
Compare
|
it is a big effort and I agree that we should merge it somewhere after release cut (not sure exactly which release are we talking about :) )
|
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
6f6c688 to
ac3984a
Compare
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
2c01ef3 to
8a5843a
Compare
flexsurfer
approved these changes
Jan 17, 2025
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
8a5843a to
dc86a53
Compare
|
@status-im/mobile-qa : PR ready for testing |
ilmotta
approved these changes
Jan 17, 2025
This commit upgrades `react-native` to `v0.75.3` Following changes were also made : - `NDK` upgraded to `26.1.10909125` - `@react-native/gradle-plugin` is set up using `includeBuild` gradle mechanism which is a better way. - `reactjs` is upgraded to `18.3.1` - `react-native-config` is upgraded to `1.5.3` - `react-native-navigation` is upgraded to `7.40.1` - `react-native-reanimated` is upgraded to `3.16.6` - `react-native-gesture-handler` is upgraded to `2.22.0` - `react-native-keychain` is upgraded to `9.2.2` - patches for react-native-navigation are updated. PR in RNN repo -> wix/react-native-navigation#7913 - patched autolinking behaviour in `react-native` to prevent generating `autolinking.json` in a gradle step. We run gradle in a sandbox with `--offline` so this is not feasible for us. We do the same thing via a nix phase called `autolinkPhase`. - `AGP` is bumped to `8.5.0` and `aapt2` is bumped to `8.5.0-11315950` - we no longer need to patch out `-X` from `script_phases-patched.sh` - `gradle` deps were updated. - `pods` were updated. - `gems` were updated.
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
dc86a53 to
7142492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades
react-nativetov0.75.3Following changes were also made :
NDKupgraded to26.1.10909125@react-native/gradle-pluginis set up usingincludeBuildgradle mechanism which is a better way.reactjsis upgraded to18.3.1react-native-configis upgraded to1.5.3react-native-navigationis upgraded to7.40.1react-native-reanimatedis upgraded to3.16.6react-native-gesture-handleris upgraded to2.22.0react-native-keychainis upgraded to9.2.2react-nativeto prevent generatingautolinking.jsonin a gradle step. We run gradle in a sandbox with--offlineso this is not feasible for us.We do the same thing via a nix phase called
autolinkPhase.AGPis bumped to8.5.0andaapt2is bumped to8.5.0-11315950-Xfromscript_phases-patched.shgradledeps were updated.podswere updated.gemswere updated.Testing notes
Intense testing is required.
Platforms
Side Effects
status: ready