Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observers clear references #298

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

anaice
Copy link
Contributor

@anaice anaice commented Jul 1, 2024

Type of PR

Bug fix

Description

Process level (CableReady::Config - @observer_peers) channel clearing.

Fixes #297

Why should this be added

Possible memory leak fix

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for cableready ready!

Name Link
🔨 Latest commit 4e77410
🔍 Latest deploy log https://app.netlify.com/sites/cableready/deploys/6683151943afa500080273f2
😎 Deploy Preview https://deploy-preview-298--cableready.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@julianrubisch julianrubisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks 👌 to me, but I'd love @hopsoft to take another look, since it was his addition initially.

@marcoroth
Copy link
Member

@hopsoft any chance you can give this a look too?

Copy link
Member

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @anaice!

@marcoroth marcoroth merged commit cc100da into stimulusreflex:main Nov 9, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible process-level memory leak
3 participants