Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observers clear references #298

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Observers clear references #298

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b05eb3
deletes corresponding process level observer when clearing a channel
anaice Jun 30, 2024
cebd85c
removes extra whitespace
anaice Jul 1, 2024
4e77410
applies coding standards
anaice Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/cable_ready/channels.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def broadcast(*identifiers, clear: true)
.select { |channel| channel.identifier.is_a?(String) }
.tap do |channels|
channels.each { |channel| @channels[channel.identifier].broadcast(clear: clear) }
channels.each { |channel| @channels.except!(channel.identifier) if clear }
channels.each { |channel| clear_channel(channel) if clear }
end
end

Expand All @@ -37,8 +37,16 @@ def broadcast_to(model, *identifiers, clear: true)
.reject { |channel| channel.identifier.is_a?(String) }
.tap do |channels|
channels.each { |channel| @channels[channel.identifier].broadcast_to(model, clear: clear) }
channels.each { |channel| @channels.except!(channel.identifier) if clear }
channels.each { |channel| clear_channel(channel) if clear }
end
end

private

def clear_channel(channel)
@channels.except!(channel.identifier)
observer = CableReady.config.observers.find { |o| o.try(:identifier) == channel.identifier }
CableReady.config.delete_observer(observer) if observer
end
end
end
Loading