-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add memory coherency logic #1176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove ".sleep", ".debug" is now handled as in-band signal (valid only during an actual transfer)
remove sleep; debug is now "in-band"
fence/fence.i now waits until the memory system repsonds "ordered" / "synchronized" condition
fixing several (minor?) design flaws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a cleaner memory synchronization (or "ordering" or "coherence") concept for the RISC-V fence isntructions. I am still not completely sure if they are implemented the right way... However, now these instructions will stall the processor until the according synchronization is accomplished:
fence
(load/store fence): flush and reload the CPU's data cache; after that flush and reload the external bus cachefence.i
(instruction-fetch fence): behave like afence
but will also invalidate the CPU's instruction cache and resets the CPU's instruction fetch front-end🐛 I've reworked the generic cache module as I had some issues with it when trying to move large data to an external DDR memory via the on-chip debugger.
debug
is now an in-band signals that corresponds to the current bus transfer. Furthermore, thesleep
signal is removed from the bus.