Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the SIP process #2

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Conversation

ramtinms
Copy link
Collaborator

This PR adds clarity to the SIP process proposal.

@ramtinms ramtinms requested review from Ramarti and LeoHChen January 15, 2025 22:26
| ------------------ | ------------------ |
| [Ramarti](https://github.com/Ramarti) | Story Protocol |
| [Ramtinms](https://github.com/ramtinms) | Story Protocol |
| [LeoHChen](https://github.com/LeoHChen) | Story Protocol |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add Ze, Meng, Kingter to maintainers list.

Copy link
Collaborator

@Ramarti Ramarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a question

create any pull request at this stage.
After thorough discussion and gathering support, it can be converted
into a SIP pull request in draft. Before this conversion, each idea requires
at least one sponsor. Sponsors are well-known community members who either
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a public list of sponsors? Or is this a fuzzy term by design?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept it open for now, as time goes and more people contribute, we might just change into contributors and maintainers. I'll clarify it in the doc.

@ramtinms ramtinms merged commit 25d68a8 into main Jan 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants