-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the SIP process #2
Changes from 5 commits
aea49f8
c73e6e8
bb10a43
dfbcc18
71c63f7
2fd3e1b
65a61fd
a021d47
e63388d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# Overview | ||
|
||
This document holds the list of contributors. | ||
|
||
## Current Contributors | ||
|
||
| Contributor Github ID | Affiliation | | ||
| ------------------ | ------------------ | | ||
| [Ramarti](https://github.com/Ramarti) | Story Protocol | | ||
| [Ramtinms](https://github.com/ramtinms) | Story Protocol | | ||
| [LeoHChen](https://github.com/LeoHChen) | Story Protocol | |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# Overview | ||
|
||
This document holds the list of maintainers. | ||
|
||
## Current Maintainers | ||
|
||
| Maintainer Github ID | Affiliation | | ||
| ------------------ | ------------------ | | ||
| [Ramarti](https://github.com/Ramarti) | Story Protocol | | ||
| [Ramtinms](https://github.com/ramtinms) | Story Protocol | | ||
| [LeoHChen](https://github.com/LeoHChen) | Story Protocol | | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -78,6 +78,23 @@ process, including its structure, lifecycle, and guidelines. For example, a | |
proposal in this category might suggest expanding SIPs into additional | ||
categories. | ||
|
||
### Access Control | ||
|
||
While this repository is open for everyone to contribute, community members | ||
are granted two levels of access to prevent spam, scams, and unrelated posts. | ||
|
||
- `Contributor`: Community members who have reviewed draft ideas in the forum | ||
can receive this role from maintainers, allowing them to create PRs in this | ||
repository. Once this role is gained it stays active for future, unless | ||
with active votes of majority of maintainers | ||
|
||
- `Maintainer`: Maintainers are community members who facilitate the process | ||
by reviewing proposal states and guiding them through the pipeline. Any | ||
proposal state change requires a majority vote from maintainers. | ||
Monthly open-to-all meetings are held to review SIPs and allocate roles. | ||
Through majority voting (2/3), maintainers can grant or revoke both contributor | ||
and maintainer roles within the community. | ||
|
||
### SIP Lifecycle | ||
|
||
Every SIP starts as an Idea and follows the lifecycle as it progresses. | ||
|
@@ -123,11 +140,18 @@ flowchart LR | |
#### Idea | ||
|
||
Every SIP begins as an idea shared with the community through [the Story | ||
's community forum](https://forum.story.foundation/). After thorough | ||
discussion and gathering | ||
support, it can be converted | ||
into a SIP draft. Before this conversion, each idea requires at least one | ||
sponsor—a well-known community member with expertise in the subject matter. | ||
's community forum](https://forum.story.foundation/). Please don't | ||
create any pull request at this stage. | ||
After thorough discussion and gathering support, it can be converted | ||
into a SIP pull request in draft. Before this conversion, each idea requires | ||
at least one sponsor. Sponsors are well-known community members who either | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a public list of sponsors? Or is this a fuzzy term by design? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I kept it open for now, as time goes and more people contribute, we might just change into contributors and maintainers. I'll clarify it in the doc. |
||
benefit from the proposal or have deep expertise in the subject matter. | ||
|
||
When an idea has received sufficient feedback and is ready to move into a | ||
draft, it can be converted into a SIP draft pull request. Opening up PRs | ||
in this repo requires a "contributor" role. If an author of the proposal | ||
does not already have a contributor role, the maintainers will add one | ||
or more of the proposal's authors to the contributor list. | ||
|
||
#### Draft | ||
|
||
|
@@ -163,7 +187,9 @@ attention. Each accepted proposal must have a tracking issue in the Story | |
repository. While proposal authors aren't necessary required to implement | ||
their proposals, this is the most effective path to completion—authors | ||
shouldn't assume other project developers will take on the implementation | ||
work. | ||
work. Unless a proposal is in living state, the proposal becomes immutable | ||
and only acceptable additions to the proposal is security considerations | ||
discovered after the fact. | ||
|
||
#### Implemented | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add Ze, Meng, Kingter to maintainers list.