Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Errors in cosmos Broadcaster are sometimes not propagated to caller #938

Merged
merged 6 commits into from
Feb 2, 2024
Merged

fix: Errors in cosmos Broadcaster are sometimes not propagated to caller #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
283fcd6
return err on code!=0 and rawLog being set
Reecepbcups Jan 9, 2024
108243c
move to `UnmarshalTxResponseBytes`
Reecepbcups Jan 9, 2024
a517b98
Merge branch 'main' into reece/propagate-broadcaster-errors
Reecepbcups Jan 9, 2024
83ee2d7
Merge branch 'main' into reece/propagate-broadcaster-errors
Reecepbcups Jan 11, 2024
1d2b58e
Merge branch 'main' into reece/propagate-broadcaster-errors
Reecepbcups Feb 2, 2024
671f3ed
remove duplicate `len(rawLog) > 2`
Reecepbcups Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions chain/cosmos/broadcaster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,15 @@ func (b *Broadcaster) UnmarshalTxResponseBytes(ctx context.Context, bytes []byte
if err := b.chain.cfg.EncodingConfig.Codec.UnmarshalJSON(bytes, &resp); err != nil {
return sdk.TxResponse{}, err
}

// persist nested errors such as ValidateBasic checks.
code := resp.Code
rawLog := resp.RawLog

if code != 0 {
return resp, fmt.Errorf("error in transaction (code: %d): raw_log: %s", code, rawLog)
}

return resp, nil
}

Expand Down
11 changes: 11 additions & 0 deletions examples/cosmos/chain_miscellaneous_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,17 @@ func testBroadcaster(ctx context.Context, t *testing.T, chain *cosmos.CosmosChai
updatedBal2, err := chain.GetBalance(ctx, addr2, chain.Config().Denom)
require.NoError(t, err)
require.Equal(t, math.NewInt(2), updatedBal2)

txResp, err = cosmos.BroadcastTx(
ctx,
b,
users[0],
banktypes.NewMsgMultiSend(banktypes.Input{
Address: addr1,
Coins: c1.Add(c2[0]),
}, out),
)
require.Error(t, err)
}

func testQueryCmd(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain) {
Expand Down
1 change: 1 addition & 0 deletions go.work.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,7 @@ github.com/rogpeppe/go-internal v1.8.0/go.mod h1:WmiCO8CzOY8rg0OYDC4/i/2WRWAB6po
github.com/rogpeppe/go-internal v1.10.0/go.mod h1:UQnix2H7Ngw/k4C5ijL5+65zddjncjaFoBhdsK/akog=
github.com/rs/xid v1.4.0/go.mod h1:trrq9SKmegXys3aeAKXMUTdJsYXVwGY3RLcfgqegfbg=
github.com/rs/zerolog v1.29.0/go.mod h1:NILgTygv/Uej1ra5XxGf82ZFSLk58MFGAUS2o6usyD0=
github.com/russross/blackfriday v1.6.0/go.mod h1:ti0ldHuxg49ri4ksnFxlkCfN+hvslNlmVHqNRXXJNAY=
github.com/ruudk/golang-pdf417 v0.0.0-20181029194003-1af4ab5afa58/go.mod h1:6lfFZQK844Gfx8o5WFuvpxWRwnSoipWe/p622j1v06w=
github.com/ruudk/golang-pdf417 v0.0.0-20201230142125-a7e3863a1245/go.mod h1:pQAZKsJ8yyVxGRWYNEm9oFB8ieLgKFnamEyDmSA0BRk=
github.com/ryancurrah/gomodguard v1.3.0/go.mod h1:ggBxb3luypPEzqVtq33ee7YSN35V28XeGnid8dnni50=
Expand Down
Loading