Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Errors in cosmos Broadcaster are sometimes not propagated to caller #938

Merged
merged 6 commits into from
Feb 2, 2024
Merged

fix: Errors in cosmos Broadcaster are sometimes not propagated to caller #938

merged 6 commits into from
Feb 2, 2024

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Jan 9, 2024 •
edited
Loading

closes #937

@Reecepbcups Reecepbcups added the BACKPORT backport into all maintained branches label Jan 9, 2024
@Reecepbcups Reecepbcups marked this pull request as ready for review January 11, 2024 03:45
@Reecepbcups Reecepbcups requested a review from a team as a code owner January 11, 2024 03:45
@Reecepbcups Reecepbcups enabled auto-merge (squash) January 11, 2024 03:46
@Reecepbcups Reecepbcups self-assigned this Jan 16, 2024
@Reecepbcups Reecepbcups changed the title fix: Errors in cosmos Broadcaster are sometimes are not propagated to caller fix: Errors in cosmos Broadcaster are sometimes not propagated to caller Feb 2, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 5:37pm

jtieri
jtieri reviewed Feb 2, 2024
View reviewed changes
chain/cosmos/broadcaster.go Outdated Show resolved Hide resolved
jtieri
jtieri approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@Reecepbcups Reecepbcups merged commit 1ac6f84 into main Feb 2, 2024
13 checks passed
@Reecepbcups Reecepbcups deleted the reece/propagate-broadcaster-errors branch February 2, 2024 17:51
mergify bot pushed a commit that referenced this pull request Feb 2, 2024
@Reecepbcups @mergify
fix: Errors in cosmos Broadcaster are sometimes not propagated to cal…
1a4898e 
…ler (#938)

(cherry picked from commit 1ac6f84)

# Conflicts:
#	go.work.sum
@mergify mergify bot mentioned this pull request Feb 2, 2024
Merged
Reecepbcups added a commit that referenced this pull request Feb 19, 2024
@mergify @Reecepbcups
[BP: v7 <- #938] fix: Errors in cosmos Broadcaster are sometimes no…
dd4589e 
…t propagated to caller (#963)

* fix: Errors in cosmos Broadcaster are sometimes not propagated to caller (#938)

(cherry picked from commit 1ac6f84)

# Conflicts:
#	go.work.sum

* fix for v7

---------

Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtieri jtieri jtieri approved these changes

@agouin agouin Awaiting requested review from agouin agouin is a code owner automatically assigned from strangelove-ventures/interchaintest-maintainers

Assignees

@Reecepbcups Reecepbcups

Labels
BACKPORT backport into all maintained branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in cosmos Broadcaster are sometimes are not propagated to caller
2 participants
@Reecepbcups @jtieri