Specify nrext64 option when creating XFS filesystem #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be very safe, we need to check the version of mkfs.xfs |
mulkieran
force-pushed
the
issue_stratisd_3504
branch
from
cf64e65 to
effbb63
Compare
mulkieran
changed the title
mulkieran
force-pushed
the
issue_stratisd_3504
branch
from
6618010 to
7bc08d1
Compare
mulkieran
force-pushed
the
issue_stratisd_3504
branch
from
7bc08d1 to
40a1b53
Compare
|
Comment fix, nothing more. |
mulkieran
force-pushed
the
issue_stratisd_3504
branch
from
40a1b53 to
e747de9
Compare
|
mulkieran
force-pushed
the
issue_stratisd_3504
branch
from
e747de9 to
64538ff
Compare
bgurney-rh
approved these changes
Nov 29, 2023
jbaublitz
reviewed
Nov 29, 2023
src/engine/strat_engine/cmd.rs
Outdated
| // package availabe that necessarily adheres to the xfsprogs versioning | ||
| // scheme. | ||
| let use_nrext64_option = match get_mkfs_xfs_version().and_then(|v| { | ||
| v.split('.') |
There was a problem hiding this comment.
We may not want to add this now, but this crate would simplify this code a lot. https://docs.rs/semver/latest/semver/
There was a problem hiding this comment.
We already depend on semver transitively. I can try using semver, but I was kind of against doing so originally, because it uses the specific crate semver rules, and I was worried that someday a version of xfsprogs would use some non-standard format and break the version parsing part. But then, I guess, we would just log the error and add in the command-line option anyway, so there's really no good reason to avoid using semver. I'll give it a go.
stratisd never uses it anymore, not since the size of the MDV was increased. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
issue_stratisd_3504
branch
from
64538ff to
e80a361
Compare
jbaublitz
approved these changes
Nov 29, 2023
|
Tests check out... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3504