Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rackAwareTopologyLabels field on bk #1196

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

ericsyh
Copy link
Member

@ericsyh ericsyh commented Dec 2, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ericsyh ericsyh requested review from a team as code owners December 2, 2024 07:08
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Dec 2, 2024
Signed-off-by: ericsyh <[email protected]>
@ericsyh ericsyh merged commit d5acec5 into master Dec 19, 2024
2 checks passed
@ericsyh ericsyh deleted the support-rackAwareTopologyLabel branch December 19, 2024 10:42
ericsyh added a commit that referenced this pull request Dec 20, 2024
* feat: support rackAwareTopologyLabels field on bk

Signed-off-by: ericsyh <[email protected]>

* support on the rackAwareTopologyLabels on sn-plaform chart

Signed-off-by: ericsyh <[email protected]>

* fix lint

Signed-off-by: ericsyh <[email protected]>

---------

Signed-off-by: ericsyh <[email protected]>
(cherry picked from commit d5acec5)
ericsyh added a commit that referenced this pull request Dec 20, 2024
* feat: support rackAwareTopologyLabels field on bk

Signed-off-by: ericsyh <[email protected]>

* support on the rackAwareTopologyLabels on sn-plaform chart

Signed-off-by: ericsyh <[email protected]>

* fix lint

Signed-off-by: ericsyh <[email protected]>

---------

Signed-off-by: ericsyh <[email protected]>
(cherry picked from commit d5acec5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants