Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rackAwareTopologyLabels field on bk #1196

Merged
merged 3 commits into from
Dec 19, 2024
Merged

feat: support rackAwareTopologyLabels field on bk #1196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c439190
feat: support rackAwareTopologyLabels field on bk
ericsyh Dec 2, 2024
173932b
support on the rackAwareTopologyLabels on sn-plaform chart
ericsyh Dec 2, 2024
1bd4043
fix lint
ericsyh Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/sn-platform-slim/templates/bookkeeper/bookkeeper-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ spec:
reclaimPolicy: {{ .Values.bookkeeper.volumes.reclaimPolicy | default "Delete" }}
{{- end }}
config:
{{- with .Values.bookkeeper.rackAwareTopologyLabels }}
rackAwareTopologyLabels:
{{- toYaml . | nindent 4 }}
{{- end }}
custom:
{{- with .Values.bookkeeper.custom }}
{{ toYaml . | indent 6 }}
Expand Down
4 changes: 4 additions & 0 deletions charts/sn-platform-slim/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,10 @@ bookkeeper:
# preferredDuringSchedulingIgnoredDuringExecution - scheduler will try to enforce but not guranentee
type: preferredDuringSchedulingIgnoredDuringExecution
topologySpreadConstraints: []
# For BookKeeperCluster, the field rackAwareTopologyLabels should be configured as nodes topology labels the value of which will be set as the rack name.
# When there are multiple labels configured, all their values will be joined by "/".
# The operator will propagate the label value from nodes to pods and ensure the pod container starts with the label values as environment variables automatically.
rackAwareTopologyLabels: []
labels: {}
annotations: {}
securityContext:
Expand Down
4 changes: 4 additions & 0 deletions charts/sn-platform/templates/bookkeeper/bookkeeper-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ spec:
reclaimPolicy: {{ .Values.bookkeeper.volumes.reclaimPolicy | default "Delete" }}
{{- end }}
config:
{{- with .Values.bookkeeper.rackAwareTopologyLabels }}
rackAwareTopologyLabels:
{{- toYaml . | nindent 4 }}
{{- end }}
custom:
{{- with .Values.bookkeeper.custom }}
{{ toYaml . | indent 6 }}
Expand Down
4 changes: 4 additions & 0 deletions charts/sn-platform/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,10 @@ bookkeeper:
# preferredDuringSchedulingIgnoredDuringExecution - scheduler will try to enforce but not guranentee
type: preferredDuringSchedulingIgnoredDuringExecution
topologySpreadConstraints: []
# For BookKeeperCluster, the field rackAwareTopologyLabels should be configured as nodes topology labels the value of which will be set as the rack name.
# When there are multiple labels configured, all their values will be joined by "/".
# The operator will propagate the label value from nodes to pods and ensure the pod container starts with the label values as environment variables automatically.
rackAwareTopologyLabels: []
labels: {}
annotations: {}
securityContext:
Expand Down
Loading