-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sophora-dashboard] introduce global value for "registry" #84
base: main
Are you sure you want to change the base?
Conversation
Makes it much easier to override the default registry. Otherwise one would have to override each and every declaration of "repository". Far worse, new repository entries would go undetected if not checked externally with e.g. Kyverno. This change should be applied to all charts.
On a second thought: We should probably add something like this
instead of simply
so that we can add third-party registries more easily:
|
I did not see this anywhere else, and I doubt that there is much benefit. I understand all this intends to do is to make it easier to replace a registry with a proxy, which now would require two lines instead of one, right? I'd rather vote to close this and leave it as it is. |
Importer is pulling three images, server is pulling four. |
Okay. I think we could do a section like this:
This is what Bitnami and KPS do and what seems to be the most standard way of doing it. |
Changed the PR to reflect this. |
Makes it much easier to override the default registry. Otherwise one would have to override each and every declaration of
repository
. Far worse, new entries would go undetected if not checked externally with e.g. Kyverno.This change should be applied to all charts.
kube-prometheus-stack
has a similar approach leveragingglobal.imageRegistry
: https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/values.yaml#L223