Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sophora-dashboard] introduce global value for "registry" #84

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[sophora-dashboard] introduce global value for "registry" #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c73d908
[sophora-dashboard] introduce global value for "registry"
muffl0n Mar 25, 2024
a29147a
[sophora-dashboard] Change to global.imageRegistry
muffl0n Apr 15, 2024
a46ac63
Merge branch 'refs/heads/main' into global-registry
muffl0n Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/sophora-admin-dashboard/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
{{- end }}
initContainers:
- name: config-generator
image: "{{ .Values.configGenerator.image.repository }}:{{ .Values.configGenerator.image.tag }}"
image: "{{ .Values.global.imageRegistry }}/{{ .Values.configGenerator.image.repository }}:{{ .Values.configGenerator.image.tag }}"
imagePullPolicy: {{ .Values.configGenerator.image.pullPolicy }}
env:
- name: SERVER_SOPHORAUSERNAME
Expand Down Expand Up @@ -96,7 +96,7 @@ spec:
mountPath: /dashboard-config
containers:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
image: "{{ .Values.global.imageRegistry }}/{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
- name: http
Expand Down
8 changes: 6 additions & 2 deletions charts/sophora-admin-dashboard/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
global:
# -- (string) image registry
imageRegistry: docker.subshell.com

# -- (int) number of replicas/pods in the statefulset
replicaCount: 1

image:
# -- (string) image repository
repository: docker.subshell.com/sophora/sophora-dashboard
repository: sophora/sophora-dashboard
# -- (string) the k8s image pull policy
pullPolicy: IfNotPresent
# -- (string) overrides the image tag
Expand All @@ -28,7 +32,7 @@ hostAliases:

configGenerator:
image:
repository: "docker.subshell.com/misc/alpine-toolkit"
repository: "misc/alpine-toolkit"
tag: "0.0.1"
pullPolicy: IfNotPresent

Expand Down
Loading