feat: Create a verify_decoded_mpt_node for a circuit
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` for readability and ease of testing
…ait. The test for whatever reason passes now, but I don't think it should.
…rcuitVariable trait.
…ven't finished implementing `verify_decoded_mpt_node`)
puma314
reviewed
Nov 9, 2023
| len_nodes[i], | ||
| finished, | ||
| ); | ||
| let mpt_node = self.decode_mpt_node::<ENCODING_LEN, ELEMENT_LEN>( |
…s, so there are some bugs.
… make it easier to debug.
…nnot merge this PR with these changes.
… circuit verificaiton logic/tests for readability & better debugging experience
… Tests still fail.
…s, which is progress.
…ing_rlp_encoding`.
…till fail, but good progress
…cates a problem with the power function. But good progress!
…sts are still incomprehensive, so there's more to do, but the logic seems more or less accurate.
…om the last commit
…ion variable, and also properly set the cubic extension challenger.
hidenori-shinohara
force-pushed
the
hide/decode-verification-circuit-succinct
branch
from
a0ab8f1 to
fdec6dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last PR #276 cleaned up and added some minor features to the verification code in vanilla Rust. This PR re-implements the same logic in the circuit language.
TODO: It probably makes sense to consolidate
MPTNodeFixedSizeandMPTValueTypebut that can be in a separate PR. This PR is already really big and I don't want to keep adding stuff.